AMAROC-768 add heigh cloud flag and allow NSC

[regDaniel]

DRAFT: Add high clouds Flag

1. Add a high clouds flag to data in case we discard more hits above MSA than MAX_HITS_OKTA0
2. Set NSC instead of NCD in case the above flag is True when we create the METAR message.

Checklists:

• New code includes dedicated tests.
• New code has been linted.
• New code follows the project's style.
• New code is compatible with the 3-Clause BSD license.
• CHANGELOG has been updated.
• AUTHORS has been updated.
• Copyright years in module docstrings have been updated.

[fpavogt]

Looks good @regDaniel. I think a small tweak is needed to handle the case when there is a significant layer (or more) in the region between the MSA and the MSA + Delta MSA

[regDaniel]

Looks good @regDaniel. I think a small tweak is needed to handle the case when there is a significant layer (or more) in the region between the MSA and the MSA + Delta MSA

absolutely. good catch, thanks! I'll take your suggestions and will think about how to best implement it.

[regDaniel]

Hi @fpavogt , thanks a lot for your review! I implemented the search for layers in buffer along your suggestions and added a test. Could you double-check if it's fine?

[fpavogt]

Looks good to me.

[loforest]

I reviewed the code and added some questions to ensure I understand the code (some docstrings might be extended accordingly) and also proposed a more explicit variable name for high_clouds_detected (to be discussed). We should also expand the Section "Scope of ampycloud" to specify that the returned NSC is only according to cloud layer height. To fully determine NSC we also need to check for the absence of convective clouds (CB/TCU) and CAVOK, which shall be done outside ampycloud using other data sources (lightning, weather radar, visibility, etc).