feat: add exactBandMatch as default false in searchAdvancedBand

src/clients/metalArchives/index.ts

@@ -2,8 +2,12 @@ import { FastifyInstance } from 'fastify'
 import { searchBandAdvanced } from './searchBandAdvanced'
 
 export const createMetalArchivesClient = (_fastify: FastifyInstance) => ({
-    searchBand: async (band: string, offset: number = 0) => {
-        return searchBandAdvanced(band, offset, true, {})
+    searchBand: async (
+        band: string,
+        exactBandMatch: boolean,
+        offset: number = 0
+    ) => {
+        return searchBandAdvanced(band, offset, exactBandMatch, {})
     }
 })
 

src/clients/metalArchives/searchBandAdvanced.ts

@@ -42,6 +42,7 @@ export const searchBandAdvanced = async (
     } = advancedSearchData
 
     const conditionalParameters = {
+        ...(exactBandMatch && { exactBandMatch }),
         ...(advancedSearchData.genre && { genre: advancedSearchData.genre }),
         ...(advancedSearchData.country && {
             country: advancedSearchData.country
@@ -62,7 +63,6 @@ export const searchBandAdvanced = async (
         url: config.metalArchives.searchBandAdvancedUrl,
         params: {
             bandName: band,
-            exactBandMatch,
             status,
             themes,
             location,

src/clients/metalArchives/test/searchBandAdvanced.test.ts

@@ -50,8 +50,7 @@ describe('searchBandAdvanced', () => {
             url: 'https://mock-api.com/search',
             params: {
                 ...searchBandAdvancedQueryFixture,
-                bandName: '',
-                exactBandMatch: false
+                bandName: ''
             }
         })
     })

src/routes/bands/handlers/search.ts

@@ -4,10 +4,14 @@ import { ServiceInfoRoutesOptions } from '../index'
 import { TypeBoxTypeProvider } from '@fastify/type-provider-typebox'
 
 const searchBand = async (data: SearchBandQuery, fastify: FastifyInstance) => {
-    const { band, offset } = data
+    const { band, exactBandMatch, offset } = data
 
     const { countTotal, countCurrent, results } =
-        await fastify.metalArchives.searchBand(band, offset)
+        await fastify.metalArchives.searchBand(
+            band,
+            exactBandMatch ?? false,
+            offset
+        )
 
     return {
         search: band,

src/routes/bands/handlers/test/search.test.ts

@@ -49,6 +49,21 @@ describe('Search Band', () => {
         expect(nock.isDone()).toBe(true)
     })
 
+    it('Should return search results, supply bandname, offset and exactBandMatch', async () => {
+        nock(config.metalArchives.searchBandAdvancedUrl)
+            .get('/')
+            .query(true)
+            .reply(200, searchBandAdvancedResponseFixture)
+
+        const response = await server.inject({
+            method: 'GET',
+            url: '/bands/search/?band=immortal&offset=0&exactBandMatch=true'
+        })
+
+        expect(response.statusCode).toEqual(200)
+        expect(nock.isDone()).toBe(true)
+    })
+
     it('Should handle empty band name', async () => {
         const response = await server.inject({
             method: 'GET',

src/routes/bands/schema/search.ts

@@ -3,7 +3,8 @@ import { bandSearchResultSchema } from '@src/shared/schema'
 
 export const searchBandQuerySchema = Type.Object({
     band: Type.String({ minLength: 1 }),
-    offset: Type.Optional(Type.Number({ minimum: 0 }))
+    offset: Type.Optional(Type.Number({ minimum: 0 })),
+    exactBandMatch: Type.Optional(Type.Boolean())
 })
 
 export type SearchBandQuery = Static<typeof searchBandQuerySchema>

src/tests/fixtures/clients/metalArchives/searchBandAdvanced.ts

@@ -5,7 +5,6 @@ import {
 
 export const searchBandAdvancedQueryFixture = {
     bandName: `immortal`,
-    exactBandMatch: true,
     status: [1, 2, 3, 4, 5, 6],
     themes: '*',
     location: '*',