-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use dockerized memote setup #9
Conversation
image: ghcr.io/metabolicatlas/memote-docker:0.13 | ||
volumes: | ||
- ${{ github.workspace }}:/project:rw | ||
options: --user root --workdir /project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where would the output json for each individual model be saved and re-accessed to enable access to the MEMOTE results?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the JSON, I chose to keep only the total resulting score, not the full JSON, which I thought would be too large.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, that makes sense. However to check for annotations we would need to extract those scores from the MEMOTE json as well. But that should be rather straight forward I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the following question:
Where would the output json for each individual model be saved an re-accessed to enable access to the MEMOTE results?
This will be relevant for a detailed report later, I think.
I'm not sure who would want to see the entire report, and why. Storing large JSONs indefinitely in the results file doesn't sound like the best place, so to find another solution more details about the use-case are needed. |
a941fe1
to
b7782f7
Compare
ee50c17
to
be22f8e
Compare
In order to save a few Actions runs. I will go ahead and merge this PR. |
This PR addresses this comment about using a Docker image of
memote
.Moreover, it adds an
index.json
containing a JSON list of GEMs to be run through the validation pipeline.