Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use dockerized memote setup #9

Merged
merged 10 commits into from
Mar 14, 2023
Merged

Conversation

mihai-sysbio
Copy link
Member

This PR addresses this comment about using a Docker image of memote.
Moreover, it adds an index.json containing a JSON list of GEMs to be run through the validation pipeline.

image: ghcr.io/metabolicatlas/memote-docker:0.13
volumes:
- ${{ github.workspace }}:/project:rw
options: --user root --workdir /project
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where would the output json for each individual model be saved and re-accessed to enable access to the MEMOTE results?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the JSON, I chose to keep only the total resulting score, not the full JSON, which I thought would be too large.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, that makes sense. However to check for annotations we would need to extract those scores from the MEMOTE json as well. But that should be rather straight forward I think.

Copy link
Collaborator

@famosab famosab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the following question:

Where would the output json for each individual model be saved an re-accessed to enable access to the MEMOTE results?

This will be relevant for a detailed report later, I think.

@mihai-sysbio
Copy link
Member Author

This will be relevant for a detailed report later, I think.

I'm not sure who would want to see the entire report, and why. Storing large JSONs indefinitely in the results file doesn't sound like the best place, so to find another solution more details about the use-case are needed.

@mihai-sysbio mihai-sysbio force-pushed the feat/memote-docker branch 3 times, most recently from a941fe1 to b7782f7 Compare March 14, 2023 10:43
@mihai-sysbio mihai-sysbio marked this pull request as ready for review March 14, 2023 11:39
@mihai-sysbio
Copy link
Member Author

In order to save a few Actions runs. I will go ahead and merge this PR.
Any remaining issue should be resolved in the target branch feat/memote. There, the discussion can continue about which JSON scores to isolate in addition to the total score (original discussion).

@mihai-sysbio mihai-sysbio merged commit d8059e3 into feat/memote Mar 14, 2023
@mihai-sysbio mihai-sysbio deleted the feat/memote-docker branch March 14, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants