-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate components to TS: ButtonLink #18889
Comments
Hello @georgewrmarshall, I'd be interested in opening up a PR to implement this change! Would you be able to assign this issue to me please? |
Can I work on this? @georgewrmarshall |
Hello @georgewrmarshall - I have begun work on migrating ButtonLink to TS however I had to stop before opening up a PR as it seems that I see that a PR is currently open to update |
Removing |
Description
Migrate
ButtonLink
component to TypeScriptDependencies
Technical Details
SNAKE_CASE
to enums inPascalCase
(name and keys)Size
notSizes
component-name.contants.js
tocomponent-name.types.ts
and add typescomponent-name.js
tocomponent-name.tsx
and add typescomponent-name.test.js
tocomponent-name.test.tsx
component-name.stories.js
tocomponent-name.stories.tsx
Acceptance Criteria
component-name
folderDifficulty: Intermediate
Good first issue for: External contributors who are familiar with TypeScript and want to contribute to improving the stability of the extension
The text was updated successfully, but these errors were encountered: