Migrate components to TS: Button

[georgewrmarshall]

Description

Migrate Button component to TypeScript

Dependencies

• Create TS version of Box component in component-library #19239
• Migrate ButtonBase to TS #19067
• Migrate components to TS: ButtonLink #18889
• Migrate components to TS: ButtonPrimary #18887
• Migrate components to TS: ButtonSecondary #18888

Technical Details

• Convert Objects in SNAKE_CASE to enums in PascalCase (name and keys)
• Ensure enums use singular not plural e.g. Size not Sizes
• Update file name from component-name.contants.js to component-name.types.ts and add types
• Update file name from component-name.js to component-name.tsx and add types
• Update file name from component-name.test.js to component-name.test.tsx
• Update file name from component-name.stories.js to component-name.stories.tsx
• Update all instances of component objects to enums
• Update all documentation

Acceptance Criteria

• Component has been converted to TypeScript
• Stories, documentation and tests have been updated inside of the component-name folder
• Before/After screen cast of component stories in storybook to show no visual regression after migration

Difficulty: Intermediate

Good first issue for: External contributors who are familiar with TypeScript and want to contribute to improving the stability of the extension

[sumitshinde-84]

i would like to work on this issue @georgewrmarshall

[georgewrmarshall]

Hi @sumitshinde-84, #18886 would be a dependency of this ticket I think this would be appropriate to take on first

[sumitshinde-84]

Hello @georgewrmarshall Additionally, please assign me the following related issues for a comprehensive approach: #18882, #18883, #18884, #18885, #18886, #18887, #18888, #18889, and #18890. Thank you for your consideration.

[georgewrmarshall]

Removing good-first-issue label until we close the Box dependency #19239

[dhruvv173]

hello @garrettbear if you have not started working on this can I work on it?

[georgewrmarshall]

Hey @dhruvv173, I'm going to assign you as @garrettbear and I will be away next week but will be able to support the following week. It has a dependency of #18888 which I would suggest you work on first. You should be able to use @garrettbear's PR for ButtonPrimary as a reference #20390

[dhruvv173]

Hey @dhruvv173, I'm going to assign you as @garrettbear and I will be away next week but will be able to support the following week. It has a dependency of #18888 which I would suggest you work on first. You should be able to use @garrettbear's PR for ButtonPrimary as a reference #20390

Sure, thank you for the update, I will work on that issue over the weekend.

[dhruvv173]

hey @georgewrmarshall can I work on this now?

[georgewrmarshall]

Hey @dhruvv173, I believe @garrettbear is working on this issue but feel free to take a look at others. All the dependencies for #19126 have been resolved. It might be a good one to take on. Thanks