-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate components to TS: AvatarAccount #18882
Comments
Hello @georgewrmarshall, I would like to take on the assigned issue as I have prior experience with the codebase and can contribute effectively. Additionally, please assign me the following related issues for a comprehensive approach: #18882, #18883, #18884, #18885, #18886, #18887, #18888, #18889, and #18890. Thank you for your consideration. |
Hey @sumitshinde-84, I have assigned this issue. I think working on one issue at a time makes sense. |
Hey @georgewrmarshall , thank you for assigning me this issue. I completely agree that focusing on one issue at a time makes sense. I'll start working on it right away. |
Removing |
can you assign this to me? @georgewrmarshall |
Assigned thanks @dhruvv173 |
hey, should I open a PR for this now that the other two which I was working on are merged? |
Description
Migrate
AvatarAccount
component to TypeScriptDependencies
Technical Details
SNAKE_CASE
to enums inPascalCase
(name and keys)Size
notSizes
component-name.contants.js
tocomponent-name.types.ts
and add typescomponent-name.js
tocomponent-name.tsx
and add typescomponent-name.test.js
tocomponent-name.test.tsx
component-name.stories.js
tocomponent-name.stories.tsx
Acceptance Criteria
component-name
folderDifficulty: Intermediate
Good first issue for: External contributors who are familiar with TypeScript and want to contribute to improving the stability of the extension
The text was updated successfully, but these errors were encountered: