Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate components to TS: AvatarAccount #18882

Closed
georgewrmarshall opened this issue Apr 29, 2023 · 7 comments · Fixed by #20208
Closed

Migrate components to TS: AvatarAccount #18882

georgewrmarshall opened this issue Apr 29, 2023 · 7 comments · Fixed by #20208
Assignees
Labels
good first issue Good for newcomers team-design-system All issues relating to design system in Extension

Comments

@georgewrmarshall
Copy link
Contributor

georgewrmarshall commented Apr 29, 2023

Description

Migrate AvatarAccount component to TypeScript

Dependencies

Technical Details

  • Convert Objects in SNAKE_CASE to enums in PascalCase (name and keys)
  • Ensure enums use singular not plural e.g. Size not Sizes
  • Update file name from component-name.contants.js to component-name.types.ts and add types
  • Update file name from component-name.js to component-name.tsx and add types
  • Update file name from component-name.test.js to component-name.test.tsx
  • Update file name from component-name.stories.js to component-name.stories.tsx
  • Update all instances of component objects to enums
  • Update all documentation

Acceptance Criteria

  • Component has been converted to TypeScript
  • Stories, documentation and tests have been updated inside of the component-name folder
  • Before/After screen cast of component stories in storybook to show no visual regression after migration

Difficulty: Intermediate

Good first issue for: External contributors who are familiar with TypeScript and want to contribute to improving the stability of the extension

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Apr 29, 2023
@sumitshinde-84
Copy link
Contributor

Hello @georgewrmarshall, I would like to take on the assigned issue as I have prior experience with the codebase and can contribute effectively. Additionally, please assign me the following related issues for a comprehensive approach: #18882, #18883, #18884, #18885, #18886, #18887, #18888, #18889, and #18890. Thank you for your consideration.

@georgewrmarshall
Copy link
Contributor Author

Hey @sumitshinde-84, I have assigned this issue. I think working on one issue at a time makes sense.

@sumitshinde-84
Copy link
Contributor

Hey @georgewrmarshall , thank you for assigning me this issue. I completely agree that focusing on one issue at a time makes sense. I'll start working on it right away.

@sumitshinde-84 sumitshinde-84 removed their assignment May 6, 2023
@georgewrmarshall georgewrmarshall added the good first issue Good for newcomers label May 12, 2023
@georgewrmarshall georgewrmarshall removed the good first issue Good for newcomers label Jun 5, 2023
@georgewrmarshall
Copy link
Contributor Author

Removing good-first-issue label until we close the Box dependency #19239

@dhruvv173
Copy link
Contributor

can you assign this to me? @georgewrmarshall

@georgewrmarshall
Copy link
Contributor Author

Assigned thanks @dhruvv173

@dhruvv173
Copy link
Contributor

Assigned thanks @dhruvv173

hey, should I open a PR for this now that the other two which I was working on are merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers team-design-system All issues relating to design system in Extension
Projects
None yet
3 participants