-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate components to TS: AvatarAccount #19004
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
hii @georgewrmarshall please review this pull request . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sumitshinde-84, thanks for your contribution. Would you be able to check your PR against a recent PR that migrates avatar base. It seems you are missing some storybook types along with some other things #18494. Also lint tests are failing
Hey @sumitshinde-84, just wanted to check in. It looks like this PR is almost there. Did you still want to work on it? If so, that's great! Let us know if you need any assistance or if there are any blockers. If you're unable to continue working on it or haven't had a chance to address it, no worries! I can take it from here and carry it forward. Cheers! |
Apologies, @georgewrmarshall. I was preoccupied with my job search, but now I am fully committed to tackling it head-on. I'm determined to find a solution. Thank you for your understanding |
Hey @sumitshinde-84, Thanks for your time and effort in creating this pull request. We have identified an issue related to the typing of the |
-->Fixes #18882