Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate components to TS: AvatarAccount #19004

Closed
wants to merge 1 commit into from

Conversation

sumitshinde-84
Copy link
Contributor

@sumitshinde-84 sumitshinde-84 commented May 4, 2023

-->Fixes #18882

@sumitshinde-84 sumitshinde-84 requested a review from a team as a code owner May 4, 2023 08:09
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sumitshinde-84
Copy link
Contributor Author

hii @georgewrmarshall please review this pull request .

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label May 5, 2023
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sumitshinde-84, thanks for your contribution. Would you be able to check your PR against a recent PR that migrates avatar base. It seems you are missing some storybook types along with some other things #18494. Also lint tests are failing

@georgewrmarshall
Copy link
Contributor

Hey @sumitshinde-84, just wanted to check in. It looks like this PR is almost there. Did you still want to work on it? If so, that's great! Let us know if you need any assistance or if there are any blockers. If you're unable to continue working on it or haven't had a chance to address it, no worries! I can take it from here and carry it forward. Cheers!

@sumitshinde-84
Copy link
Contributor Author

Apologies, @georgewrmarshall. I was preoccupied with my job search, but now I am fully committed to tackling it head-on. I'm determined to find a solution. Thank you for your understanding

@georgewrmarshall
Copy link
Contributor

Hey @sumitshinde-84, Thanks for your time and effort in creating this pull request. We have identified an issue related to the typing of the Box component, specifically with the polymorphic as prop. To address this issue, we have an open ticket at #19239 and a draft pull request at #19363 that needs to be merged before we can proceed with your PR. Because this PR is 2 weeks old I am going to close it. Feel free to create another PR once the dependency issue has been resolved.

@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-contributor team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate components to TS: AvatarAccount
2 participants