Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoresolve support #6208

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Autoresolve support #6208

wants to merge 4 commits into from

Conversation

Scoppio
Copy link
Collaborator

@Scoppio Scoppio commented Nov 18, 2024

Extracts interface for some "end of game" events, this small necessary change is necessary for the implementation of an autoresolve feature that integrates with the Resolve Scenario wizard.

MegaMek/mekhq#5155

@Scoppio Scoppio self-assigned this Nov 18, 2024
@HammerGS
Copy link
Member

Is this still in Development, also could we get a description so we know what it does.

Copy link
Member

@HammerGS HammerGS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See note regarding Description and status

@HammerGS HammerGS marked this pull request as draft November 24, 2024 22:41
@Scoppio
Copy link
Collaborator Author

Scoppio commented Nov 25, 2024

See note regarding Description and status
Added the information. This pull request is necessary for all the multiple works I am doing on auto-resolve right now. Also this is very minor, non-functional and does not cause any kind of effects anywhere else.

void gameVictory(GameVictoryEvent e);

void gameVictory(PostGameResolution e);

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'e' is never used.
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.01%. Comparing base (60a4fe0) to head (23a2d45).
Report is 101 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #6208   +/-   ##
=========================================
  Coverage     29.01%   29.01%           
- Complexity    13982    13984    +2     
=========================================
  Files          2649     2649           
  Lines        268128   268128           
  Branches      47723    47723           
=========================================
+ Hits          77798    77801    +3     
+ Misses       186445   186440    -5     
- Partials       3885     3887    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Scoppio Scoppio marked this pull request as ready for review November 27, 2024 01:03
@Scoppio
Copy link
Collaborator Author

Scoppio commented Nov 27, 2024

See note regarding Description and status

I talked with Illiani, we will move forward with this one, as the other type of autoresolve I am planning is in the back burner and may take longer than expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants