Fix error with the formatter

[TheMasterCado]

There is an error described in the issue #15 .

This implement the described fix and it's now working for the following versions:

SimpleCov 0.21.1
Rspec-rails 4.0.2
Rails 6.1

[mdlima]

👍

[mcrampon]

Suggested change

	if SimpleCov.minimum_coverage[:line]&.positive?
	if covered_percent >= SimpleCov.minimum_coverage[:line]
	if coverage_minimum&.positive?
	if covered_percent >= coverage_minimum

With:

    def coverage_minimum
      @coverage_minimum ||= begin
        minimums = SimpleCov.minimum_coverage
        minimums.is_a?(Hash) ? minimums[SimpleCov.primary_coverage] : minimums
      end
    end

This ensures that we use the minimum corresponding to the primary coverage (which is not necessary :line)

[TheMasterCado]

I implemented your changes, let me know if I need to change anything else !

[mcrampon]

I think you didn't mean to add those spaces here 😜

[MarcGrimme]

Could you please remove the empty line?

[mcrampon]

I implemented your changes, let me know if I need to change anything else !

I'm not affiliated in any way to this project. Was just here because I encountered the same bug you did. Not sure if the owner still maintains this repo. Maybe we can tag them? @MarcGrimme wdyt?

[MarcGrimme]

We also need some tests (changed to the latest interface of SimpleCov) to cover the behaviour. Could you add that too?

[MarcGrimme]

Could you please remove the empty line?

[MarcGrimme]

Could you also remove the old line_coverage_minimum method. I guess it's not needed any more.

[joeyates]

Hi @MarcGrimme

I would like to make a suggestion which I hope will unblock this situation: bump the minimum version of simplecov to '0.18'.

Currently, this gem supports ~> 0.17. Actually, both the 0.17 and 0.18 relases are pretty old (see simplecov tags) so I would imagine removing support for 0.17 is not a big problem.

By excluding versions less than 0.18, there is no longer a need to handle the different types of SimpleCov.minimum_coverage - it will always be a Hash. Without this, the CI setup would need to test against both a simplecov gem <0.18 and one >0.18.

If that sounds acceptable, I can open a new PR which bumps the simplecov version and includes the new behavior.

[MarcGrimme]

Thanks @joeyates for being constructive. In the mean time I bumped as you proposed the versions used for this gem. We now have a simplecov-small-badge in version 0.2.6 that should support more modern ruby versions (3.2.x).
I tested the gem and it seems fine to me. I also adjusted the cosmetic change proposed in this PR :line to SimpleCov.primary_coverage.
Let me know if that works.