Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/linecoverage #1

Merged
merged 2 commits into from
Mar 21, 2022
Merged

Bugfix/linecoverage #1

merged 2 commits into from
Mar 21, 2022

Conversation

inveterateliterate
Copy link
Collaborator

First time I tried the gem I got an error that .positive? is not a method on Hash.

I traced this back to an error with the method:

def line_coverage_minimum
      minimums = SimpleCov.minimum_coverage
      minimums.is_a?(Hash) ? minimums[:line] : minimums
    end

Where seemingly the shape of SimpleCov.minimum_coverage had maybe changed or was not what the last line of the method expected.

Looking at the open issues and the PRs on the gem, someone already solved this issue with a PR, but the PR has not been merged and this gem seems to not be maintained. Note, despite this being unmaintained, it feels generally low risk, and will keep an eye on depandabot alerts for any security concerns.

As a result, forked this gem and leveraged this authors suggested update: MarcGrimme#16

@inveterateliterate inveterateliterate merged commit ce5ca7b into master Mar 21, 2022
@inveterateliterate inveterateliterate deleted the bugfix/linecoverage branch March 21, 2022 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant