Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional role link #471

Merged
merged 12 commits into from
May 20, 2021
+20 −0
Merged

Conditional role link #471

Changes from 9 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c267510
Update links demo to include change of projection work
prushforth Apr 16, 2021
c56bc14
Add demo by Ahmad / Peter to demo folder. Clean up by moving some dem…
prushforth Apr 23, 2021
2d58987
Clean up demo directory a bit
prushforth May 6, 2021
357323c
Update continuous integration to only execute on pull requests, remov…
prushforth May 7, 2021
9b297be
Merge demo-cleanup
prushforth May 12, 2021
5c4d546
Add role='application' to FeatureGroup <g> element
prushforth May 18, 2021
484e6a8
Merge branch 'master' of https://github.com/Maps4HTML/Web-Map-Custom-…
prushforth May 18, 2021
6a7395e
Merge branch 'master' of https://github.com/Maps4HTML/Web-Map-Custom-…
prushforth May 20, 2021
b2cb86b
Conditionally create role="link" on graphics that are wrapped with <m…
prushforth May 20, 2021
717d0c2
Change role="application" to role="button" on featureGroup,
prushforth May 20, 2021
4516155
Add <svg role="none presentation"... so that each feature is not anno…
prushforth May 20, 2021
551c4d7
Remove obsolete comment
prushforth May 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/mapml/features/featureGroup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,11 @@ export var FeatureGroup = L.FeatureGroup.extend({
if(layers.length === 1 && firstLayer.options.link) this.options.link = firstLayer.options.link;
if(this.options.link){
M.Feature.prototype.attachLinkHandler.call(this, this.options.group, this.options.link, this.options._leafletLayer);
this.options.group.setAttribute('role', 'link');
} else {
this.options.group.setAttribute("aria-expanded", "false");
// fix issue https://github.com/Maps4HTML/Web-Map-Custom-Element/issues/423
prushforth marked this conversation as resolved.
Show resolved Hide resolved
this.options.group.setAttribute('role', 'application');
prushforth marked this conversation as resolved.
Show resolved Hide resolved
this.options.onEachFeature(this.options.properties, this);
this.off("click", this._openPopup);
}
Expand Down