Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional role link #471

Merged
merged 12 commits into from
May 20, 2021
Merged

Conversation

prushforth
Copy link
Member

Make role="application" or role="link" attribute of featureGroup conditional on whether the graphic is a link or simply a popup.

@Malvoz I noticed that links were not being announced. I think this resolves it, or improves the experience a little.

@Malvoz
Copy link
Member

Malvoz commented May 20, 2021

Where can I test links? I know we have featureLinks.html but that uses <map> so that's not going to be accessible in all browsers no matter our efforts.

@prushforth
Copy link
Member Author

A couple here, I'll add another example

http://maps4html.org/experiments/painting/

@Malvoz
Copy link
Member

Malvoz commented May 20, 2021

In my testing NVDA announces: Graphic, Girl zoom equals 2, Link.

If role="none" (and space separated/or presentation, these are synonyms, latter is legacy role) is set on the parent <svg>, it is not announced as Graphic and the output is: Girl zoom equals 2, Link which I think is more appropriate.

Or maybe we want Graphic to be announced? I guess it's not inaccurate.

@prushforth prushforth requested a review from Malvoz May 20, 2021 18:04
Copy link
Member

@Malvoz Malvoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noted that there's a comment that probably should be removed. Other than that LGTM!

@prushforth prushforth merged commit e1264b8 into Maps4HTML:master May 20, 2021
@prushforth prushforth deleted the conditional-role-link branch May 20, 2021 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants