-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conditional role link #471
Conditional role link #471
Conversation
…os to the experiments repo, where they will be publicly usable.
Where can I test links? I know we have featureLinks.html but that uses |
A couple here, I'll add another example |
In my testing NVDA announces: If Or maybe we want |
which makes more sense when announced
…unced as "Graphic".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noted that there's a comment that probably should be removed. Other than that LGTM!
Make role="application" or role="link" attribute of featureGroup conditional on whether the graphic is a link or simply a popup.
@Malvoz I noticed that links were not being announced. I think this resolves it, or improves the experience a little.