Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follows updated keyboard interaction rules #292

Merged
merged 7 commits into from
Feb 16, 2021

Conversation

ahmadayubi
Copy link
Member

@ahmadayubi ahmadayubi commented Feb 12, 2021

This PR:

  • Doubles size of crosshair
  • Focuses + (Zoom control) instead of parent div when clicking >|
  • Doesn't hide the crosshair on keypresses as the crosshair is meant to indicate focus
  • Space and Enter now query top layer
  • Pressing Esc or closing using the close button now focuses the map afterwards with the crosshair visible
  • Tabbing out of query popup focuses controls
  • Shift + Tabbing out of query popup focuses map
  • Shift + Tabbing out of feature popup focuses the current feature
  • Re-adds close button to features popup

Closes #291

@ahmadayubi ahmadayubi marked this pull request as ready for review February 16, 2021 20:05
@prushforth prushforth merged commit 87f5a50 into Maps4HTML:master Feb 16, 2021
@prushforth
Copy link
Member

Travis has run out of runway, disabling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query handling keyboard access
2 participants