Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape key does not dismiss popup in Firefox #465

Closed
prushforth opened this issue May 18, 2021 · 1 comment · Fixed by #520
Closed

Escape key does not dismiss popup in Firefox #465

prushforth opened this issue May 18, 2021 · 1 comment · Fixed by #520
Assignees
@ben-lu-uw
Labels
bug
Milestone
Fall term 2021

Comments

@prushforth
Copy link
Member

... but it does in Chrome.

Possibly related to one of these, or a regression/omission perhaps.
@prushforth prushforth added the bug label May 18, 2021
@Malvoz
Copy link
Member

Malvoz commented May 18, 2021 •
edited
Loading

Yes that'd be this item:

I must've only tested in Chrome...

@prushforth prushforth added this to the Fall term milestone Jul 30, 2021
This was referenced Sep 27, 2021
Closed
Merged
@ben-lu-uw ben-lu-uw self-assigned this Sep 28, 2021
@ben-lu-uw ben-lu-uw linked a pull request Sep 29, 2021 that will close this issue
Use e.composedPath in addition to e.path for firefox compatibility #520
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ben-lu-uw ben-lu-uw

Labels
bug
Projects
None yet
Milestone
Fall term 2021
Development

Successfully merging a pull request may close this issue.

Use e.composedPath in addition to e.path for firefox compatibility ben-lu-uw/Web-Map-Custom-Element
3 participants
@prushforth @Malvoz @ben-lu-uw