Fix :attr:.ManimConfig.format not updating movie file extension
#3839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonGrace2282
added
the
pr:bugfix
JasonGrace2282
changed the title
.ManimConfig.format not updating movie file extension
|
should we add a test for this? |
|
Good idea, I'm not sure how I forgot that :) |
JasonGrace2282
force-pushed
the
fix-config
branch
from
059e5a2 to
a790285
Compare
behackl
reviewed
Jul 13, 2024
| ("mp4", ".mp4"), | ||
| ("webm", ".webm"), | ||
| ("mov", ".mov"), | ||
| ("gif", ".mp4"), |
There was a problem hiding this comment.
It is somewhat odd how differently we are treating the case of .gif, but that's a different discussion.
There was a problem hiding this comment.
I think it's just a missed edge case, probably worth fixing (wow we have a lot of problems with ManimConfig xD)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3837
Example of Bug