-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed behavior of config.background_opacity < 1
and duplicated log messages
#3680
Fixed behavior of config.background_opacity < 1
and duplicated log messages
#3680
Conversation
Setting background_transparency=0.0 should have the same effect than setting transparent=True. The output format must be compatible with transparency (.mov, .webm). Otherwise ffpmeg fails. This patch ensures that background_transparency=0.0 triggers the change of the output format. Also a WARNING is raised about the change in the output format. I want to thank @SirJamesClarkMaxwell for inspiring me to tackle this issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Wouldn't actually any value for |
for more information, see https://pre-commit.ci
I've pushed some fixes for the behavior of It would be great if someone could cross-review my changes, otherwise I'm happy to get this merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took a look at the changes, mostly looks good to me. I did leave some comments, so I would appreciate if you or @behackl could take a look :)
I also have one question now: with this change, should we just have a per-file logger with logger = logging.getLogger("manim")
? If so, would it make sense to remove the logger
from being exported in manim._config
?
Sidenote:
I was actually having similar problems on experimental so maybe this will help out :)
config.background_opacity=0
failingconfig.background_opacity < 1
and duplicated log messages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one idea - otherwise LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually just realized there is a line added that was added in another PR (#3839 )
The other changes look useful, so maybe just merge main into this branch and I'll double check then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh nice, I love git :)
LGTM, for real, this time.
Setting background_transparency=0.0 should have the same effect than setting transparent=True. The output format must be compatible with transparency (.mov, .webm). Otherwise ffpmeg fails.
This patch ensures that background_transparency=0.0 triggers the change of the output format. Also a WARNING is raised about the change in the output format.
I want to thank @SirJamesClarkMaxwell for inspiring me to tackle this issue.
Overview: What does this pull request change?
Motivation and Explanation: Why and how do your changes improve the library?
Links to added or changed documentation pages
Further Information and Comments
Reviewer Checklist