Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: convert non-.wav/.raw files to .wav before passing to pydub #3832

Merged
merged 10 commits into from
Aug 14, 2024
Merged

bugfix: convert non-.wav/.raw files to .wav before passing to pydub #3832

merged 10 commits into from
Aug 14, 2024

Conversation

behackl
Copy link
Member

@behackl behackl commented Jun 30, 2024 •
edited
Loading

Ongoing post-pyav refactor: fixes #3831

  • cleanup inconsistently named containers/streams in added code
  • think about actually opening file to check codec
  • deal with files that have mulitple audio streams? (try whether this actually works currently)
  • maybe add a test?

@behackl behackl mentioned this pull request Jul 1, 2024
Closed
@behackl behackl added the pr:bugfix Bug fix for use in PRs solving a specific issue:bug label Jul 14, 2024
@behackl behackl added this to the v0.19.0 milestone Jul 14, 2024
@behackl behackl marked this pull request as ready for review July 14, 2024 21:41
@behackl
Copy link
Member Author

behackl commented Jul 14, 2024

I've cleaned up the re-encoding of non-wav/raw files, made sure the solution also works with multiple audio channels, and added a test. Ready to be reviewed!

The test uses the manim_caplog fixture introduced in #3680, so it will only pass after that PR is merged.

JasonGrace2282
JasonGrace2282 approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@JasonGrace2282 JasonGrace2282 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JasonGrace2282 JasonGrace2282 enabled auto-merge (squash) August 14, 2024 15:19
@JasonGrace2282 JasonGrace2282 merged commit d029beb into ManimCommunity:main Aug 14, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonGrace2282 JasonGrace2282 JasonGrace2282 approved these changes

Assignees
No one assigned
Labels
pr:bugfix Bug fix for use in PRs solving a specific issue:bug
Projects
Dev Board
Status: ✅ Done
Milestone
v0.19.0
Development

Successfully merging this pull request may close these issues.

Post PyAV-Refactor: make sure pydub is only fed .wav or .raw files
2 participants
@behackl @JasonGrace2282