Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace vendored dependencies #334

Merged
merged 1 commit into from
Nov 3, 2024
Merged

Conversation

orhun
Copy link
Contributor

@orhun orhun commented Nov 3, 2024

This PR removes the following vendored dependencies:

  • ansi-to-tui: 7.0.0 is out which supports the latest version of Ratatui.
  • color-to-tui: Not needed. Ratatui supports de/serialization via serde feature.

@grtcdr
Copy link
Member

grtcdr commented Nov 3, 2024

Hi Orhun,

Thanks for the patches, I presume the new vendoring model would have made the Arch PKGBUILD more complex than it ought to be.

ansi-to-tui: 7.0.0 is out which supports the latest version of Ratatui.

I'll try and work more closely with the upstream package to ensure version conflicts do not affect us going forward.

color-to-tui: Not needed. Ratatui supports de/serialization via serde feature.

I had no idea, very nice! Named, indexed and hex colors are all supported, so this change looks good to me.

Thanks for all the help!

This closes #333, I'll let the affected maintainers know that we're reverting the vendoring model in favor of this pull request.

@grtcdr grtcdr merged commit fa7a9a9 into Macchina-CLI:main Nov 3, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants