Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaging for Cargo is temporarily discontinued; we'd like your opinion #333

Closed
grtcdr opened this issue Oct 30, 2024 · 3 comments
Closed
Labels
status/help-wanted Your help is needed.

Comments

@grtcdr
Copy link
Member

grtcdr commented Oct 30, 2024

I recently made the decision to discontinue packaging macchina on crates.io, this change can be traced back to this commit.

That change was my attempt at providing a solution to a recurring problem we've been having concerning two packages we share a dependency with, ansi-to-tui and color-to-tui (macchina and these two packages all share a dependency on ratatui).

We have been having monthly reports of build issues (#320 #326 #332) for people installing the package using cargo and despite a number of attempts to pin down the version numbers of ratatui, ansi-to-tui and color-to-tui, the issue would always come back.

I'm posting this issue to gather feedback on this decision and to arrive at a better solution than I could come up with and ultimately to find consensus.

If you have any ideas as to what we can do to avoid future build errors whilst still maintaining a presence on crates.io, please let us know.

Note that @0323pin has reached out to me (in a private email) about how the changes in the aforementioned commit have affected him as a package maintainer. If you too are maintaining macchina for users of your distribution, we value your opinion and would love to hear your feedback as well.

@grtcdr grtcdr added the status/help-wanted Your help is needed. label Oct 30, 2024
@grtcdr
Copy link
Member Author

grtcdr commented Oct 30, 2024

@123marvin123 and @uttarayan21 I'd love to hear your thoughts on this one.

@grtcdr
Copy link
Member Author

grtcdr commented Nov 3, 2024

@0323pin I've just merged #334, the included changes are a far better solution than vendoring, the next release will not include the current submodules. I apologize for all the trouble my "fix" put you through.

@0323pin
Copy link
Contributor

0323pin commented Nov 3, 2024

That's good. But, it was rather straightforward and I've learnt something new.

@grtcdr grtcdr closed this as completed Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/help-wanted Your help is needed.
Development

No branches or pull requests

2 participants