Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix challenge mode #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix challenge mode #6

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25c61c3
Fix strdup() check after parsing received challenge.
cron2 Aug 7, 2018
f50e180
Make authentication with challenge work.
cron2 Aug 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 23 additions & 24 deletions src/pam_linotp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -610,7 +610,7 @@ int linotp_auth(char *user, char *password,
erase_string(*challenge);
}
}
if ((*challenge) || (*stat)) {
if ((*challenge == NULL) || (*state == NULL)) {
log_error("strdup failed during linotp_auth!");
returnValue = PAM_ABORT;
} else
Expand Down Expand Up @@ -1152,31 +1152,30 @@ int pam_linotp_get_authtok_no_use_first_pass(
*/

int ret = PAM_AUTHTOK_ERR;
/* tokenlength is 0, if there was no configurated token_length,
* so we cant ask for !(*token_length).
*/
if(!(token_length)) {
log_error("no token length given (pam_linotp_get_authtok)");
return PAM_AUTH_ERR;

/* Using prompt to ask for password */
if (!prompt){
prompt = "Your OTP: ";
}
log_debug("Using Prompt '%s' to get login data", prompt);
if(hide_otp_input){
ret = pam_prompt(pamh, PAM_PROMPT_ECHO_OFF, (char **)password, "%s", prompt);
} else {
/* Using prompt to ask for password */
log_debug("Using Prompt to get login data");
if (!prompt){
prompt = "Your OTP: ";
}
if(hide_otp_input){
ret = pam_prompt(pamh, PAM_PROMPT_ECHO_OFF, (char **)password, "%s", prompt);
} else {
ret = pam_prompt(pamh, PAM_PROMPT_ECHO_ON, (char **)password, "%s", prompt);
}
if (!password || ret != PAM_SUCCESS){
log_debug("cant get password");
return PAM_AUTHTOK_ERR;
}
log_debug("OTP received successfully %s", *password);
*token_length = (size_t)strlen(*password);
return ret;
ret = pam_prompt(pamh, PAM_PROMPT_ECHO_ON, (char **)password, "%s", prompt);
}
if (!password || ret != PAM_SUCCESS){
log_debug("cant get password");
return PAM_AUTHTOK_ERR;
}
log_debug("OTP received successfully %s", *password);
if(!(token_length)) {
log_error("no token length given (pam_linotp_get_authtok)");
}
else
{
*token_length = (size_t)strlen(*password);
}
return ret;
}

int pam_linotp_get_authtok(pam_handle_t *pamh, char **password, char **cleanpassword,
Expand Down