Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unreachable links in markdown files #1219

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

Andrei-Aksionov
Copy link
Collaborator

Hi there 👋

As it turned out, VSCode has built-in feature to validate local links in markdown files.
So after I checked all the .md files, I found a few “dead” links.

@rasbt
Copy link
Collaborator

rasbt commented Mar 30, 2024

Super cool, I didn't know about this!

@rasbt rasbt enabled auto-merge (squash) March 30, 2024 13:44
@Andrei-Aksionov
Copy link
Collaborator Author

PyTorch Lightning has a CI for this: https://github.com/Lightning-AI/pytorch-lightning/blob/master/.github/workflows/ci-check-md-links.yml
Maybe LitGPT should also have it, since there are a lot of tutorials and it's easy to make a mistake.
@carmocca @awaelchli ?

@rasbt
Copy link
Collaborator

rasbt commented Mar 30, 2024

This would be a nice addon imho!

@carmocca carmocca disabled auto-merge March 30, 2024 15:18
@carmocca carmocca merged commit 6d04a87 into Lightning-AI:main Mar 30, 2024
7 of 8 checks passed
@Andrei-Aksionov Andrei-Aksionov deleted the fix_tutorials_links branch March 30, 2024 15:20
rasbt pushed a commit that referenced this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants