Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed prepare_dataset path in 0_to_litgpt.md #1218

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

EswarDivi
Copy link
Contributor

No description provided.

@rasbt
Copy link
Collaborator

rasbt commented Mar 29, 2024

Thanks, much appreciated @EswarDivi !

@rasbt rasbt enabled auto-merge (squash) March 29, 2024 18:55
@rasbt rasbt merged commit 81d7cf3 into Lightning-AI:main Mar 29, 2024
8 checks passed
@Andrei-Aksionov
Copy link
Collaborator

Hey @rasbt
VSCode has built-in link validator which is disabled by default. It wouldn't help in this case, but it found another issue:

 
**More information and additional resources**

- [tutorials/convert_lit_models](tutorials/convert_lit_models.md): Tutorial on converting LitGPT weights

Since tutorials are in the same folder, the path should be ./convert_lit_models.md. (Or just convert_lit_models.md also works).

But it checks only local link, for the external link you need some another extension.

@Andrei-Aksionov
Copy link
Collaborator

I decided to create a PR with fixes: #1219

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants