-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework DIP package generator #75
Conversation
24ca43e
to
10214e1
Compare
This is the result of librepcb-parts-generator PR 75: LibrePCB/librepcb-parts-generator#75 - IPC 7351-C conforming names - Updated dimensions (based on JEDEC and real-world package sizes) - New silkscreen conforming to IPC 7351-C recommendations - Use lead span for pad x-offset, not package width Version has been bumped to v0.2.0.
This is the result of librepcb-parts-generator PR 75: LibrePCB/librepcb-parts-generator#75 - IPC 7351-C conforming names - Updated dimensions (based on JEDEC and real-world package sizes) - New silkscreen conforming to IPC 7351-C recommendations - Use lead span for pad x-offset, not package width Version has been bumped to v0.2.0.
This is the result of librepcb-parts-generator PR 75: LibrePCB/librepcb-parts-generator#75 - IPC 7351-C conforming names - Updated dimensions (based on JEDEC and real-world package sizes) - New silkscreen conforming to IPC 7351-C recommendations - Use lead span for pad x-offset, not package width Version has been bumped to v0.2.0.
This is the result of librepcb-parts-generator PR 75: LibrePCB/librepcb-parts-generator#75 - IPC 7351-C conforming names - Updated dimensions (based on JEDEC and real-world package sizes) - New silkscreen conforming to IPC 7351-C recommendations Version has been bumped to v0.2.0.
Generally very nice rework & documentation! 🚀 I didn't review everything in detail yet, but my comments so far:
If you agree on these changes but don't have the time to implement it, maybe we could do it the same way as for the LED generator that I implement the changes in a separate PR? |
@dbrgn may I rebase this branch and apply the suggestions from #75 (comment)? Since this is almost ready it would be nice to finally get it merged :) |
Sorry, I forgot about this PR... Sure, your suggestions sound reasonable, go ahead 🙂 |
- Bumped version 0.1 -> 0.1.1 - UUIDs not affected
- Updated dimensions (based on JEDEC and real-world package sizes) - Deprecated a few DIP packages: DIP-36, DIP-48, DIP-52 and DIP-64 (since they have practically no real-world use, and if they do the packages sometimes deviate from the standard sizes, so generic packages shouldn't be used) - New silkscreen conforming to IPC7351C recommendations - Use lead span for pad x-offset, not package width - Port most of the generator to the new entity wrapper types - Add courtyard Version has been bumped to v0.2.0.
Alright, I rebased and added two commits with these changes:
Result: |
This is the result of librepcb-parts-generator PR 75: LibrePCB/librepcb-parts-generator#75 - IPC 7351-C conforming names - Updated dimensions (based on JEDEC and real-world package sizes) - New silkscreen conforming to IPC 7351-C recommendations Version has been bumped to v0.2.0.
- Change lead span from the outer values to the nominal values 7.62mm & 15.24mm. - Reduce body width by 0.4mm on each side. - Merge notch polygon into top silkscreen polygon. - Extend top silkscreen polygon to include a pin-1 marking. - Move pin-1 dot to documentation layer and move to the inner of the body. - Add a package outline polygon. - Reduce text to body distance from 0.8mm to 0.6mm. - Add an approval for the missing 3D models.
This is the result of librepcb-parts-generator PR 75: LibrePCB/librepcb-parts-generator#75 - IPC 7351-C conforming names - Updated dimensions (based on JEDEC and real-world package sizes) - New silkscreen conforming to IPC 7351-C recommendations Version has been bumped to v0.2.0.
🎉 |
This is a total rework of DIP package generator. Another one of those PRs where I thought "let me quickly do those changes", but then I spent a total of 10-15 hours on it 😅 (Mostly research)
Version has been bumped to v0.2.0.
This PR also includes the changes by @ouabache in #73. Fixes #32.
I'll create a PR against the base library for easier discussion.