Use IPC names for DIP packages #73
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bumped version 0.1 -> 0.1.1 changed create date to 2020 1/18 12:00:00 UUIDs not affected
|
Thanks! We follow PEP8 to keep the code style consistent. For checking, we use flake8, you can install it (e.g. via There are a few failures reported by the tool. Could you fix them? Here are the failures, mostly about horizontal alignment, which PEP8 recommends against: |
dbrgn
requested changes
Jan 18, 2020
Closed
|
Try it now.
I don't know what the trailing B is for but I removed it.
…On Sat, Jan 18, 2020 at 1:08 PM Danilo Bargen ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Added a few change suggestions.
------------------------------
In generate_dip.py
<#73 (comment)>
:
> @@ -253,7 +266,7 @@ def _make(dirpath: str) -> None:
keywords='dip,pdip,cdip,cerdip,dual inline package',
pins=[4, 6, 8, 14, 16, 18, 20, 24, 28],
top_offset=0.8255,
- create_date='2018-11-04T23:13:00Z',
+ create_date='2020-01-18T12:00:00Z',
The create date doesn't need to be updated, this is just used for the
first version (and may actually be removed in the future, since it does not
bring much benefit).
⬇️ Suggested change
- create_date='2020-01-18T12:00:00Z',
+ create_date='2018-11-04T23:13:00Z',
------------------------------
In generate_dip.py
<#73 (comment)>
:
> @@ -265,6 +278,6 @@ def _make(dirpath: str) -> None:
keywords='dip,pdip,cdip,cerdip,dual inline package,wide',
pins=[24, 28, 32, 36, 40, 48, 52, 64],
top_offset=0.8255,
- create_date='2018-11-04T23:13:00Z',
+ create_date='2020-01-18T12:00:00Z',
Same here:
⬇️ Suggested change
- create_date='2020-01-18T12:00:00Z',
+ create_date='2018-11-04T23:13:00Z',
------------------------------
In generate_dip.py
<#73 (comment)>
:
> @@ -103,15 +106,25 @@ def _uuid(identifier: str) -> str:
uuid_pkg = _uuid('pkg')
uuid_pads = [_uuid('pad-{}'.format(p)) for p in range(1, pin_count + 1)]
-
+
+ # IPC-7251 name Example: DIP762W52P254L1905H508Q14B
+ # DIP + width + W lead_width + P spacing + L pin_package_offset*2 +(pin_count/2)* spacing + H component_height + Q pin_count B
Would be great if you could use IPC terminology (like "lead span") so that
the terms we use are consistent across generators.
⬇️ Suggested change
- # DIP + width + W lead_width + P spacing + L pin_package_offset*2 +(pin_count/2)* spacing + H component_height + Q pin_count B
+ # DIP + lead span + W lead width + P pitch + L body length + H component height + Q pin count B
------------------------------
In generate_dip.py
<#73 (comment)>
:
> # General info
lines.append('(librepcb_package {}'.format(uuid_pkg))
- lines.append(' (name "{}-{} {}mm")'.format(name, pin_count, width))
+ lines.append(' (name "DIP{:.0f}W{:.0f}P{:.0f}L{:.0f}H{:.0f}Q{}B")'.format(DIP,W,P,L,H,Q))
Is the trailing B there for the density level? I'd drop that, since a
package can have multiple density levels as footprint variants.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#73?email_source=notifications&email_token=AAKX3XG26ACUIKERQOHXZZLQ6NVTZA5CNFSM4KIT2IP2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSH3IQQ#pullrequestreview-344962114>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKX3XGKDQIAK724DDMWA6TQ6NVTZANCNFSM4KIT2IPQ>
.
|
|
Thanks! There are still some warnings generated by I noticed that the way we calculate the top offset (using a fixed offset independent from the pin count) is actually wrong. I will fix that, and will integrate your name changes into the PR with those fixes. |
|
I will run flake8 on both the generate_bga and generate_pga scripts. They
will both have a ton of errors
…On Sun, Jan 19, 2020 at 7:19 AM Danilo Bargen ***@***.***> wrote:
Thanks! There are still some warnings generated by flake8. I'll fix them
myself.
I noticed that the way we calculate the top offset (using a fixed offset
independent from the pin count) is actually wrong. I will fix that, and
will integrate your name changes into the PR with those fixes.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#73?email_source=notifications&email_token=AAKX3XDE4N4WHFPJYJL4XWDQ6RVPLA5CNFSM4KIT2IP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJKUUOA#issuecomment-576014904>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKX3XHM5FZW6QGND3X2ZLDQ6RVPLANCNFSM4KIT2IPQ>
.
|
|
OK Both generate_pga,py and generate_bga.py are lint clean
On Sun, Jan 19, 2020 at 9:57 AM Ouabache Designworks <[email protected]>
wrote:
… I will run flake8 on both the generate_bga and generate_pga scripts. They
will both have a ton of errors
On Sun, Jan 19, 2020 at 7:19 AM Danilo Bargen ***@***.***>
wrote:
> Thanks! There are still some warnings generated by flake8. I'll fix them
> myself.
>
> I noticed that the way we calculate the top offset (using a fixed offset
> independent from the pin count) is actually wrong. I will fix that, and
> will integrate your name changes into the PR with those fixes.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#73?email_source=notifications&email_token=AAKX3XDE4N4WHFPJYJL4XWDQ6RVPLA5CNFSM4KIT2IP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJKUUOA#issuecomment-576014904>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAKX3XHM5FZW6QGND3X2ZLDQ6RVPLANCNFSM4KIT2IPQ>
> .
>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bumped version 0.1 -> 0.1.1
changed create date to 2020 1/18 12:00:00
UUIDs not affected