Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

B2CA-901: improve ragger tests #554

Merged
merged 35 commits into from
Apr 11, 2024
Merged

B2CA-901: improve ragger tests #554

merged 35 commits into from
Apr 11, 2024

Conversation

cedelavergne-ledger
Copy link
Contributor

@cedelavergne-ledger cedelavergne-ledger commented Mar 27, 2024 •
edited
Loading

Improve Ragger tests, by porting:

  • speculos tests
  • zemu tests

Also, fix ragger tests pylint issues

Remaining 1 test on zemu: send_etc.test.js, running app-ethereum-classic, and using app-ethereum as a library. It doesn't work yet with ragger. To be investigate

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/B2CA-901_improve-ragger-tests branch 7 times, most recently from fcf7953 to 779f891 Compare March 29, 2024 13:30
@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/B2CA-901_improve-ragger-tests branch 4 times, most recently from a974ac6 to d5b3665 Compare April 4, 2024 15:23
@cedelavergne-ledger cedelavergne-ledger marked this pull request as ready for review April 4, 2024 15:45
@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/B2CA-901_improve-ragger-tests branch 15 times, most recently from c0fa58c to f2c85ed Compare April 9, 2024 07:03
@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/B2CA-901_improve-ragger-tests branch from 80db8f8 to 6242327 Compare April 11, 2024 14:48
apaillier-ledger
apaillier-ledger requested changes Apr 11, 2024
View reviewed changes
tests/ragger/test_clone.py Outdated Show resolved Hide resolved
tests/ragger/test_eip191.py Outdated Show resolved Hide resolved
tests/ragger/test_eip191.py Outdated Show resolved Hide resolved
.github/workflows/build_and_functional_tests.yml Outdated Show resolved Hide resolved
@cedelavergne-ledger
Port 'send_etc.test' from 'zemu' to 'ragger'
d4b6e5c 
- Port test config from 'zemu'
- Copy snapshots from 'zemu'
- Adapt conftest.py to support library mode
- Add a new test step in the workflow
@cedelavergne-ledger
Remove 'zemu' tests
5f7d312
@cedelavergne-ledger
Update documentation
da284a1
@cedelavergne-ledger
Remove client installation, and use local module with symlink
29630f9
@cedelavergne-ledger
Remove redundant test_eip1559
ae6c7bf
@cedelavergne-ledger
Remove redundant tests from test_sign
473c252
@cedelavergne-ledger
remove redundant test_get_public_key
bce536c
@cedelavergne-ledger
Move test eip2930 to test_sign
c75c687
@cedelavergne-ledger
Use settings_toggle function to simplify the code
f549117
@cedelavergne-ledger
Update amounts to smaller values to ease screen reading
962c9f3
@cedelavergne-ledger
Rename 'test_get_pk2' to 'test_get_eth2_pk' and use rather ETH2 publi…
152a332 
…c address
@cedelavergne-ledger
Remove useless 'test_legacy_etc' ragger snapshots
8fcaf9f
@cedelavergne-ledger
Improve 'ROOT_SNAPSHOT_PATH' with latest ragger version
c9436ab
@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/B2CA-901_improve-ragger-tests branch from ca7bcb2 to c9436ab Compare April 11, 2024 16:08
@cedelavergne-ledger cedelavergne-ledger merged commit a27c984 into develop Apr 11, 2024
121 checks passed
@cedelavergne-ledger cedelavergne-ledger deleted the cev/B2CA-901_improve-ragger-tests branch April 11, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apaillier-ledger apaillier-ledger apaillier-ledger approved these changes

@fbeutin-ledger fbeutin-ledger Awaiting requested review from fbeutin-ledger

Assignees

@cedelavergne-ledger cedelavergne-ledger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cedelavergne-ledger @apaillier-ledger