Clean clone test for better readability

.github/workflows/build_and_functional_tests.yml

@@ -33,26 +33,20 @@ jobs:
       download_app_binaries_artifact: "ragger_elfs"
 
   build_clone_app:
-    name: Build Clone application using the reusable workflow
-    uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_build.yml@v1
-    with:
-      upload_app_binaries_artifact: "clone_elfs"
-
-  build_main_app:
     name: Build Main app using the reusable workflow
     uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_build.yml@v1
     with:
       flags: "CHAIN=thundercore"
-      upload_app_binaries_artifact: "main_elfs"
+      upload_app_binaries_artifact: "clone_elfs"
 
   ragger_clone_tests:
-    name: Run ragger tests using the reusable workflow for lib context
+    name: Run ragger Clone tests using the reusable workflow
     needs:
+      - build_application
       - build_clone_app
-      - build_main_app
     uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_ragger_tests.yml@v1
     with:
-      download_app_binaries_artifact: "clone_elfs"
-      additional_app_binaries_artifact: "main_elfs"
-      additional_app_binaries_artifact_dir: ./tests/.test_dependencies/main/build/
+      download_app_binaries_artifact: "ragger_elfs"
+      additional_app_binaries_artifact: "clone_elfs"
+      additional_app_binaries_artifact_dir: ./tests/ragger/.test_dependencies/clone/build/
       test_options: "--with_lib_mode"

tests/ragger/conftest.py

@@ -17,8 +17,8 @@ def pytest_addoption(parser):
     parser.addoption("--with_lib_mode", action="store_true", help="Run the test with Library Mode")
 
 
-parent: Path = Path(__file__).parent.parent
-testFiles = glob.glob("test_*.py", root_dir=f"{parent}/ragger")
+parent: Path = Path(__file__).parent
+testFiles = glob.glob("test_*.py", root_dir=f"{parent}")
 collect_ignore = []
 if "--with_lib_mode" in sys.argv:
 
@@ -28,11 +28,7 @@ def pytest_addoption(parser):
 
     warnings.warn("Main app is started in library mode")
 
-    # Check dependencies directory exists
-    test_dir: Path = Path(parent, ".test_dependencies")
-    assert test_dir.exists()
-
-    configuration.OPTIONAL.MAIN_APP_DIR = "tests/.test_dependencies/"
+    configuration.OPTIONAL.MAIN_APP_DIR = "tests/ragger/.test_dependencies/"
 
     collect_ignore += [f for f in testFiles if "test_clone" not in f]
 

tests/ragger/snapshots/nanosp/test_clone_thundercore

@@ -0,0 +1 @@
+../nanox/test_clone_thundercore

tests/ragger/test_clone.py

@@ -13,20 +13,20 @@
 NONCE = 68
 GAS_PRICE = 13
 GAS_LIMIT = 21000
-VALUE = 31415926913374232
+VALUE = 0.31415
 
 
 # Legacy Zemu etc with clone: Transfer on Ethereum clone app
-def test_clone_etc(firmware: Firmware,
-                   backend: BackendInterface,
-                   navigator: Navigator,
-                   test_name: str):
+def test_clone_thundercore(firmware: Firmware,
+                           backend: BackendInterface,
+                           navigator: Navigator,
+                           test_name: str):
     tx_params: dict = {
         "nonce": NONCE,
         "gasPrice": Web3.to_wei(GAS_PRICE, 'gwei'),
         "gas": GAS_LIMIT,
         "to": ADDR,
-        "value": VALUE,
+        "value": Web3.to_wei(VALUE, "ether"),
         "chainId": 108
     }
-    common(firmware, backend, navigator, tx_params, test_name)
+    common(firmware, backend, navigator, tx_params, test_name, BIP32_PATH)