Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standard_plugin.mk: Remove DISABLE_UI #532

Merged
merged 2 commits into from
Feb 7, 2024
Merged

standard_plugin.mk: Remove DISABLE_UI #532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71e2281
standard_plugin.mk: Remove DISABLE_UI
Feb 7, 2024
5e382ea
Updated plugin SDK changelog file
apaillier-ledger Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src_plugin_sdk/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,13 @@
| :rotating_light: | Breaks build |
| :warning: | Breaks compatibility with app |

## [latest](/) - 2024/02/02
## [latest](/) - 2024/02/07

### Removed

* UI disabler

## [2250549](/../../commit/2250549) - 2024/02/02

### Changed

Expand Down
16 changes: 0 additions & 16 deletions src_plugin_sdk/standard_plugin.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,6 @@ ifeq ($(BOLOS_SDK),)
$(error Environment variable BOLOS_SDK is not set)
endif

# Prevent compilation of BAGL/NBGL
# Has to be before any SDK include
DISABLE_UI = 1

include $(BOLOS_SDK)/Makefile.defines

APPVERSION ?= "$(APPVERSION_M).$(APPVERSION_N).$(APPVERSION_P)"
Expand Down Expand Up @@ -60,16 +56,4 @@ DISABLE_STANDARD_BAGL_UX_FLOW = 1
DISABLE_DEBUG_LEDGER_ASSERT = 1
DISABLE_DEBUG_THROW = 1

# Required for PRINTFs to compile
ifeq ($(DEBUG),0)
DISABLE_STANDARD_SEPROXYHAL = 1
endif

# So the plugin can still access the necessary NBGL types and pass its icon to
# the Ethereum app
ifeq ($(TARGET_NAME),TARGET_STAX)
DEFINES += HAVE_NBGL
INCLUDES_PATH += $(BOLOS_SDK)/lib_nbgl/include $(BOLOS_SDK)/lib_ux_stax
endif

include $(BOLOS_SDK)/Makefile.standard_app
Loading