Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

standard_plugin.mk: Remove DISABLE_UI #532

Merged
merged 2 commits into from
Feb 7, 2024
Merged

standard_plugin.mk: Remove DISABLE_UI #532

merged 2 commits into from
Feb 7, 2024

Conversation

xchapron-ledger
Copy link
Contributor

This is causing too many hurdles for too few perks.

Description

standard_plugin.mk: Remove DISABLE_UI

This is causing too many hurdles for too few perks.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

standard_plugin.mk: Remove DISABLE_UI
71e2281 
This is causing too many hurdles for too few perks.
fbeutin-ledger
fbeutin-ledger previously approved these changes Feb 7, 2024
View reviewed changes
@xchapron-ledger xchapron-ledger merged commit 9f6a187 into develop Feb 7, 2024
92 of 96 checks passed
@xchapron-ledger xchapron-ledger deleted the xch/plugin-sdk-remove-ui-disabler branch February 7, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apaillier-ledger apaillier-ledger apaillier-ledger approved these changes

@fbeutin-ledger fbeutin-ledger fbeutin-ledger left review comments

Assignees

@xchapron-ledger xchapron-ledger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xchapron-ledger @apaillier-ledger @fbeutin-ledger