Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect assumption on max possible chain ID size #497

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Fix incorrect assumption on max possible chain ID size #497

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/shared_context.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,14 +176,15 @@ typedef enum {
#endif
} contract_call_t;

#define NETWORK_STRING_MAX_SIZE 16
// must be able to hold in decimal up to : floor(MAX_UINT64 / 2) - 36
#define NETWORK_STRING_MAX_SIZE 19

typedef struct txStringProperties_s {
char fullAddress[43];
char fullAmount[79]; // 2^256 is 78 digits long
char maxFee[50];
char nonce[8]; // 10M tx per account ought to be enough for everybody
char network_name[NETWORK_STRING_MAX_SIZE];
char network_name[NETWORK_STRING_MAX_SIZE + 1];
} txStringProperties_t;

#ifdef TARGET_NANOS
Expand Down
Loading