Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect assumption on max possible chain ID size #497

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Fix incorrect assumption on max possible chain ID size #497

merged 1 commit into from
Nov 17, 2023

Conversation

apaillier-ledger
Copy link
Contributor

@apaillier-ledger apaillier-ledger commented Nov 17, 2023 •
edited
Loading

Description

Would make transactions with very large (but still within specs) chain IDs be refused by the device.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@fbeutin-ledger fbeutin-ledger merged commit 5dbbfd1 into develop Nov 17, 2023
88 of 93 checks passed
@fbeutin-ledger fbeutin-ledger deleted the fix/apa/max_chain_id branch November 17, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbeutin-ledger fbeutin-ledger fbeutin-ledger approved these changes

Assignees

@apaillier-ledger apaillier-ledger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apaillier-ledger @fbeutin-ledger