Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lua] Change bind to use retail accurate random duration #6194

Merged

Conversation

TracentEden2
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

This PR changes the duration of the spell bind and bindga to have a random duration (as on retail). I performed retail testing/captures that is summarized here for both player->mob and mob->player. Essentially, after discussing with some magic people, the current best estimation is bind duration is drawn from a normal distribution with mean of 30s, std. dev. of 12 seconds, min of 1 sec, and max of 60 seconds. The random nature of bind duration (along with the max duration) is further supported by JP wiki here.

Steps to test these changes

Bind mobs and watch the duration.

@TracentEden2 TracentEden2 changed the title Change bind to use retail accurate random duration [Lua] Change bind to use retail accurate random duration Aug 30, 2024
@claywar claywar merged commit 4fd5c52 into LandSandBoat:base Sep 1, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants