Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind spells duration has a floor of 5 seconds if not fully resisted. #6588

Open
wants to merge 1 commit into
base: base
Choose a base branch
from

Conversation

blueBounder
Copy link

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

This is a follow up on an earlier PR #6194 that implemented bind's random duration.
This earlier PR implemented bind's random duration with a floor of 1 second when not fully resisted, leading to instances of the spell's effect wearing off almost immediately.
Further capture data supports a floor for bind's duration when not fully resisted of 5 seconds.
Further discussion can be found in discord thread here.

Steps to test these changes

  1. Find a mob that is not bind immune
  2. Cast bind and wait for the spell to wear off naturally
  3. Verify time difference is between 5 and 60 seconds
  4. Repeat many, many times.
  5. Find a mob that is stun immune- verify change did not break this as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants