Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BCNM] Make Ifrit TBF and TSTBF more retail accurate #6114

Open
wants to merge 1 commit into
base: base
Choose a base branch
from

Conversation

TracentEden2
Copy link
Contributor

@TracentEden2 TracentEden2 commented Aug 17, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Adjusts Ifrit Prime for Trial by Fire aka TBF and Trial Size Trial by Fire aka TSTBF to be more retail accurate.

This is done by first splitting the TBF Ifrit and TSTBF Ifrit into two separate luas (as they have different logic and having separate helps with readability and understandability).

TBF is given several retail accurate mods including status immunities, fire absorb, enfire effect, udmgphy, udmgrange, and sight and magic aggro ranges. The TBF skill list was corrected by removing Inferno (which it was using as normal skill) and adding Burning Strike and Fire VI. Also the Ifrit mystic avatars (from temenos) that were also using the TBF skill list were changed to use a different Ifrit skill list that better aligns with the fact that they can use any Ifrit skills.

TSTBF is given the same immunities, udmgphy, udmgrange, and sight and magic aggro ranges as TBF. However the enfire damage level was changed to be accurate to retail videos (as no captures exist), 3000 TP is given on engage as retail videos show mobskill use on engage. And a LIGHT_MEVA of -35 is given so that searing light resist rate roughly matches that seen in retail videos (24/27 unresisted searing lights from my checking).

TBF, TSTBF, and ASA were given the correct job of drk/blm (like player avatars).

The changes were based on captures including here and here, a personal capture I will upload, trial by fire videos like here and here, and trial size trial by videos (of all different avatars) for searing light resist rate and MEVA change. Also mystic avatar change based on capture here.

This is prequel to a series of PRs that will be adding the Waking the Beast (WTB) quest starting with Ifrit. However to keep PRs more compact I wanted to add these changes first and then Ifrit WTB in a separate PR.

Steps to test these changes

Fight TBF and TSTBF to check changes

@TracentEden TracentEden force-pushed the make_ifrit_tbf_tstbf_more_accurate branch from 0d9a045 to 8be283a Compare August 19, 2024 22:15
@TracentEden2 TracentEden2 changed the title Make Ifrit TBF and TSTBF more retail accurate [BCNM] Make Ifrit TBF and TSTBF more retail accurate Aug 23, 2024
@Xaver-DaRed
Copy link
Contributor

This has conflicts. Rebase it whenever you can and it will be ready to go.

@TracentEden TracentEden force-pushed the make_ifrit_tbf_tstbf_more_accurate branch from 8be283a to c3ed66c Compare September 1, 2024 14:02
@TracentEden2
Copy link
Contributor Author

This has conflicts. Rebase it whenever you can and it will be ready to go.

Yep, I fixed the conflicts now, thanks!

@TracentEden TracentEden force-pushed the make_ifrit_tbf_tstbf_more_accurate branch 2 times, most recently from ef7ec9b to 2a784fd Compare September 7, 2024 18:07
@TracentEden TracentEden force-pushed the make_ifrit_tbf_tstbf_more_accurate branch from 2a784fd to 6010882 Compare September 29, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants