Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Add Stoneskin subpower interactions for Ruszor mobskills #5734

Draft
wants to merge 1 commit into
base: base
Choose a base branch
from

Conversation

ampitere
Copy link
Contributor

@ampitere ampitere commented May 14, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Adds Stoneskin subpower interactions support for some unique types of Stoneskin, one which absorbs only physical and the other which only absorbs magic, breath, and non-elemental damage.

Steps to test these changes

https://www.bg-wiki.com/ffxi/Category:Ruszor

  1. !zone Beaucedine Glacier [S]
  2. !mobhere 17334289
  3. !exec target:useMobAbility(2438) - Frozen Mist
  4. Effect should absorb 1000 physical damage, while active mob will absorb Ice damage
  5. !exec target:useMobAbility(2439) - Hydro Wave
  6. Effect should absorb 1500 magic, breath, and non-elemental damage, while active mob will absorb Water damage

@ampitere ampitere force-pushed the add_stoneskin_subpower_interactions branch from d021299 to a2b70ad Compare May 14, 2024 22:05
@ampitere
Copy link
Contributor Author

Going to keep this as a draft until mobskills are done.

@ampitere ampitere marked this pull request as draft May 14, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant