Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LUA] Add Frozen Mist and Hydro Wave mobskills #5731

Merged

Conversation

ampitere
Copy link
Contributor

@ampitere ampitere commented May 14, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Adds Frozen Mist and Hydro Wave mobskills. Requires implementing some unique types of Stoneskin, one which absorbs only physical and the other which only absorbs magic, breath, and non-elemental damage (to be done in #5734) Resolves #201

Steps to test these changes

https://www.bg-wiki.com/ffxi/Category:Ruszor

  1. !zone Beaucedine Glacier [S]
  2. !mobhere 17334289

Frozen Mist - https://wiki.ffo.jp/html/21510.html

  1. !exec target:useMobAbility(2438)
  2. !getmod ICE_ABSORB
  3. Effect should absorb 1000 physical damage, while active mob will absorb Ice damage (JP wiki says 1000, bg-wiki says 1500) - will be implemented in [Core] Add Stoneskin subpower interactions for Ruszor mobskills #5734

Hydro Wave - https://wiki.ffo.jp/html/24705.html

  1. !exec target:useMobAbility(2439)
  2. !getmod WATER_ABSORB
  3. Effect should absorb 1500 magic, breath, and non-elemental damage, while active mob will absorb Water damage - will be implemented in [Core] Add Stoneskin subpower interactions for Ruszor mobskills #5734

@UmeboshiXI
Copy link
Contributor

The special effects for the Ruszor mobskills are a result of changing the mob's AnimationSub.

AnimationSub:
0 = "Normal"
1 = "Bubbly Effect"
2 = "Frosty/Ice Effect"

@ampitere ampitere force-pushed the add_frozen_mist_hydro_wave_mobskills branch 8 times, most recently from 81b110f to 9a29ba8 Compare May 14, 2024 18:34
@ampitere ampitere marked this pull request as ready for review May 14, 2024 18:34
@ampitere ampitere force-pushed the add_frozen_mist_hydro_wave_mobskills branch from 9a29ba8 to 8f3e58b Compare May 14, 2024 18:36
@ampitere ampitere changed the title [Core] Add Frozen Mist and Hydro Wave mobskills - WIP [Core] Add Frozen Mist and Hydro Wave mobskills May 14, 2024
@ampitere ampitere force-pushed the add_frozen_mist_hydro_wave_mobskills branch 2 times, most recently from b51de73 to 80c2a9c Compare May 14, 2024 19:32
@ampitere ampitere force-pushed the add_frozen_mist_hydro_wave_mobskills branch 2 times, most recently from 8ff9ddd to 8e8966b Compare May 14, 2024 21:54
@ampitere ampitere changed the title [Core] Add Frozen Mist and Hydro Wave mobskills [LUA] Add Frozen Mist and Hydro Wave mobskills May 14, 2024
@ampitere ampitere force-pushed the add_frozen_mist_hydro_wave_mobskills branch 5 times, most recently from 6712cfe to fdda78f Compare May 15, 2024 01:47
@ampitere ampitere force-pushed the add_frozen_mist_hydro_wave_mobskills branch from fdda78f to 45fda17 Compare May 15, 2024 01:55
@ampitere
Copy link
Contributor Author

Will need to change these to target self once #5745 is merged.

@claywar claywar merged commit f8a0c35 into LandSandBoat:base May 16, 2024
11 checks passed
@ampitere ampitere deleted the add_frozen_mist_hydro_wave_mobskills branch May 16, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Ruszor mob skills, because BLU spell Sub-Zero Smash is not learnable
5 participants