Move Jailer of Faith QM every 30 minutes #4552
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Moves the Jailer of Faith QM exactly every 30 minutes from when it lasts appears. The original implementation is completely broken, as mentioned in #3632. There is some slight contention on whether it moves every 30 minutes or 15 minutes, but as best as I can tell it was either updated in a patch to 30 minutes, or people are confusing the generic 15m (at the time) respawn on QMs vs the 30m move timer.
The code mimics Phantom Worm's movement code but requires some extra logic to track the case where JoF may pop and die before the timer triggers, requiring the timer to be reset (which is not particularly easy and instead I opted to just start a second timer and ignore the initial timer when it triggers). Phantom Worm conveniently ignores this problem because the move timer is so short it's not really noticeable.
I did not update Ix'Drk but if this PR goes through I can give it similar treatment.
Steps to test these changes
5 locations for pop:
-- North / Hume tower !pos -420 0 -157 35
-- NE / Elvaan tower !pos -157 0 -340 35
-- SE / Galka tower !pos -260 0 -643 35
-- SW / Tarutaru tower !pos -580 0 -644 35
-- NW / Mithra tower !pos -683 0 -340 35
!additem 1899 for HQ euvhi organ
It's much easier to test by changing the timer to 30 seconds!