Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Jailer of Faith QM Spawn #3244 #3561

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

9001-Sols
Copy link

@9001-Sols 9001-Sols commented Oct 17, 2023

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

Please enter a player-facing description

Jailer of Faith Quest Marker will now only move once every 30 minutes.

What does this pull request do? (Please be technical)

Replaces the Jailer of Faith Spawn Randomiser code to pattern match Ix'Drk, and only move the ??? around once every 30 minutes.

Steps to test these changes

  • Watch the Jailer of Faith ??? to see it move
  • Confirm that it doesn't move again within 30 minutes
  • (Bonus) Kill Jailer of Faith and confirm that the ??? respawns 15 minutes after the time of death, and that it doesn't move for at least 30 minutes after spawning

Special Deployment Considerations

N/A

Related Issue

#3244

@9001-Sols 9001-Sols changed the title Fix JoF Spawn #3244 Fix Jailer of Faith QM Spawn #3244 Oct 17, 2023
@lapislosh
Copy link

This is a lot better than how it currently is although imo the best way is it use a timer like how Phantom/Morion Worm work, so that it actually moves every 30m instead of on the first game hour change after 30m.

I had a PR for LSB that I never got around to fixing that does this, except I made it more complicated than it needed to be and I had never gotten back around to simplifying it LandSandBoat#4552 All the code in the PR for checking multiple timers, etc. needs to be ripped out and instead just call clearTimer when JoF is popped.

dallano
dallano previously approved these changes Oct 17, 2023
Copy link

@dallano dallano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you for the PR

@Frankie-hz Frankie-hz merged commit 8f4de5a into AirSkyBoat:staging Oct 24, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants