Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 32 bit downloads for nightly #389

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove 32 bit downloads for nightly #389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2e6e15
remove 32 bit downloads for nightly
Rossmaxx Nov 13, 2024
edbfa65
Fix typo
Rossmaxx Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions lib/Artifacts.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,6 @@ private static function platformFromArtifactName(string $artifactName): Platform
case 'macos': return Platform::MacOS;
case 'macos-arm64': return Platform::MacOS;
case 'macos-x86_64': return Platform::MacOS;
case 'mingw32': return Platform::Windows;
case 'mingw64': return Platform::Windows;
default: return Platform::Unknown;
}
Expand All @@ -125,7 +124,6 @@ private static function platformNameFromArtifactName(string $artifactName): stri
case 'macos': return 'macOS 10.15+';
case 'macos-arm64': return 'macOS (Apple Silicon)';
case 'macos-x86_64': return 'macOS (Intel)';
case 'mingw32': return 'Windows 32-bit';
case 'mingw64': return 'Windows 64-bit';
default: return 'Unknown (' . $artifactName . ')';
}
Expand Down
3 changes: 2 additions & 1 deletion templates/download/index.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,8 @@
<div id="prerelease" class="text-center">
<small>
<span class="fas fa-exclamation-circle"></span>
{% trans %}Downloads labeled Alpha, Beta, or Nightly are pre-release software, stability may suffer.{% endtrans %}
{% trans %}Downloads labeled Alpha, Beta, or Nightly are pre-release software, stability may suffer.{% endtrans %}<br>
Note: 32 bit nightly builds no longer available.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove the warning, personally. Other opinions welcome.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The warning is necessary, as people need to be aware.

When all older versions are listed and not nightlies, atleast a simple warning should be displayed to explain the missing download.

</small>
</div>
{% endif %}
Expand Down