Remove 32 bit downloads for nightly #389
Conversation
I think this might be due to the github keys not available for me locally. Or is it something different? |
|
LMMS/lmms#7286 is the issue. |
Co-authored-by: FyiurAmron <[email protected]>
|
I think this PR is misdirected because it removes 32-bit builds from showing EVEN WHEN THEY'RE BUILT EVEN FOR PAST BUILDS. This doesn't really make sense. If we're to stop building 32-bit builds moving forward on the main repository, it'll save us CI time and they'll just stop appearing on our PRs and nightly pages. |
Probably GitHub rate limiting on your PC.
|
|
So basically, i can just remove from the CI and it'll stop showing up?? Then why did i think of removing the option from the website first? |
| @@ -65,7 +65,8 @@ | |||
| <div id="prerelease" class="text-center"> | |||
| <small> | |||
| <span class="fas fa-exclamation-circle"></span> | |||
| {% trans %}Downloads labeled Alpha, Beta, or Nightly are pre-release software, stability may suffer.{% endtrans %} | |||
| {% trans %}Downloads labeled Alpha, Beta, or Nightly are pre-release software, stability may suffer.{% endtrans %}<br> | |||
| Note: 32 bit nightly builds no longer available. | |||
There was a problem hiding this comment.
I would remove the warning, personally. Other opinions welcome.
There was a problem hiding this comment.
The warning is necessary, as people need to be aware.
When all older versions are listed and not nightlies, atleast a simple warning should be displayed to explain the missing download.
Well, your PR also tells the user WHY they're missing, so your train of thought isn't wrong if enough people disagree this comment: #389 (comment). |
I've started to remove 32 bit support in the CI and this is the first step. Per LMMS/lmms#6614 (comment) by @tresf
TODO: