Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean #14

Open
wants to merge 29 commits into
base: dev
Choose a base branch
from
Open

Clean #14

Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
92a2912
Add/improve section label
hsonne Oct 12, 2024
0f8c88c
Reindent
hsonne Oct 12, 2024
5e61a4c
Loop over names instead of indices
hsonne Oct 12, 2024
9983cb0
Move function definition out of if (FALSE)
hsonne Oct 12, 2024
b3c59c0
Simplify and generalise
hsonne Oct 12, 2024
7294310
Do not next "if (FALSE)"
hsonne Oct 12, 2024
cb60bc0
Clean section "Read and plot solute"
hsonne Oct 12, 2024
85b03bc
Add and clean section "Read and plot balance"
hsonne Oct 12, 2024
0f7c0a6
Move things to where they belong
hsonne Oct 12, 2024
3beca45
Add/clean more sections
hsonne Oct 12, 2024
dc35e52
Move tlevel expressions after tlevel assignment
hsonne Oct 12, 2024
2d035d9
Move expressions to where they seem to belong
hsonne Oct 12, 2024
6d26794
Get rid of duplication in "dry" and "wet" case
hsonne Oct 13, 2024
c459abc
Integrate kd() into prepare_solute_input()
hsonne Oct 13, 2024
e581ea9
Integrate get_mean() into provide_soil_columns()
hsonne Oct 13, 2024
ee72f27
Integrate halftime_to_firstorderrate()
hsonne Oct 13, 2024
e1a551b
Use helper function index_of()
hsonne Oct 13, 2024
758effd
Move MAIN section to the top of the script
hsonne Oct 13, 2024
97e68f0
Move provide_soil_columns() up
hsonne Oct 13, 2024
d45c3a1
Extract period definition
hsonne Oct 13, 2024
f017790
Use kwb.utils::startsToRanges() and compare
hsonne Oct 13, 2024
9831b6a
Keep only the new version
hsonne Oct 13, 2024
272ad78
Rename generate_solute_ids()
hsonne Oct 13, 2024
49ee82b
Move main loop up into MAIN section
hsonne Oct 13, 2024
ceabdb9
Provide directory structure and files locally
hsonne Oct 13, 2024
e9dc490
Move provide_paths() up
hsonne Oct 13, 2024
662f107
Replace path constant with placeholder
hsonne Oct 13, 2024
1cddc08
Return early, use inline assignment
hsonne Oct 13, 2024
e7b2062
WIP
hsonne Oct 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading