Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean #14

Open
wants to merge 29 commits into
base: dev
Choose a base branch
from
Open

Clean #14

wants to merge 29 commits into from

Commits on Oct 12, 2024

  1. Add/improve section label

    @hsonne
    hsonne committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    92a2912 View commit details
    Browse the repository at this point in the history

  2. Reindent

    @hsonne
    hsonne committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    0f8c88c View commit details
    Browse the repository at this point in the history

  3. Loop over names instead of indices

    @hsonne
    hsonne committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    5e61a4c View commit details
    Browse the repository at this point in the history

  4. Move function definition out of if (FALSE)

    @hsonne
    hsonne committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    9983cb0 View commit details
    Browse the repository at this point in the history

  5. Simplify and generalise 

    extrahiere_letzte_[drei_]teile()
    @hsonne
    hsonne committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    b3c59c0 View commit details
    Browse the repository at this point in the history

  6. Do not next "if (FALSE)"

    @hsonne
    hsonne committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    7294310 View commit details
    Browse the repository at this point in the history

  7. Clean section "Read and plot solute"

    @hsonne
    hsonne committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    cb60bc0 View commit details
    Browse the repository at this point in the history

  8. Add and clean section "Read and plot balance"

    @hsonne
    hsonne committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    85b03bc View commit details
    Browse the repository at this point in the history

  9. Move things to where they belong

    @hsonne
    hsonne committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    0f7c0a6 View commit details
    Browse the repository at this point in the history

  10. Add/clean more sections

    @hsonne
    hsonne committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    3beca45 View commit details
    Browse the repository at this point in the history

  11. Move tlevel expressions after tlevel assignment

    @hsonne
    hsonne committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    dc35e52 View commit details
    Browse the repository at this point in the history

  12. Move expressions to where they seem to belong

    @hsonne
    hsonne committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    2d035d9 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2024

  1. Get rid of duplication in "dry" and "wet" case

    @hsonne
    hsonne committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    6d26794 View commit details
    Browse the repository at this point in the history

  2. Integrate kd() into prepare_solute_input()

    @hsonne
    hsonne committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    c459abc View commit details
    Browse the repository at this point in the history

  3. Integrate get_mean() into provide_soil_columns()

    @hsonne
    hsonne committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    e581ea9 View commit details
    Browse the repository at this point in the history

  4. Integrate halftime_to_firstorderrate() 

    into prepare_solute_input()
    @hsonne
    hsonne committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    ee72f27 View commit details
    Browse the repository at this point in the history

  5. Use helper function index_of()

    @hsonne
    hsonne committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    e1a551b View commit details
    Browse the repository at this point in the history

  6. Move MAIN section to the top of the script 

    and put it in "if (FALSE)"
    @hsonne
    hsonne committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    758effd View commit details
    Browse the repository at this point in the history

  7. Move provide_soil_columns() up

    @hsonne
    hsonne committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    97e68f0 View commit details
    Browse the repository at this point in the history

  8. Extract period definition

    @hsonne
    hsonne committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    d45c3a1 View commit details
    Browse the repository at this point in the history

  9. Use kwb.utils::startsToRanges() and compare 

    with what generate_solute_ids() returns
    @hsonne
    hsonne committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    f017790 View commit details
    Browse the repository at this point in the history

  10. Keep only the new version

    @hsonne
    hsonne committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    9831b6a View commit details
    Browse the repository at this point in the history

  11. Rename generate_solute_ids() 

    to generate_index_ranges() and reused it.
Delete generate_periods() (not needed any more)
    @hsonne
    hsonne committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    272ad78 View commit details
    Browse the repository at this point in the history

  12. Move main loop up into MAIN section

    @hsonne
    hsonne committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    49ee82b View commit details
    Browse the repository at this point in the history

  13. Provide directory structure and files locally

    @hsonne
    hsonne committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    ceabdb9 View commit details
    Browse the repository at this point in the history

  14. Move provide_paths() up

    @hsonne
    hsonne committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    e9dc490 View commit details
    Browse the repository at this point in the history

  15. Replace path constant with placeholder 

    TODO: replace the placeholder (back) in a cleaner way
    @hsonne
    hsonne committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    662f107 View commit details
    Browse the repository at this point in the history

  16. Return early, use inline assignment

    @hsonne
    hsonne committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    1cddc08 View commit details
    Browse the repository at this point in the history

  17. WIP

    @hsonne
    hsonne committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    e7b2062 View commit details
    Browse the repository at this point in the history