-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PR #329 #494
Fix PR #329 #494
Conversation
Co-authored-by: Romain Dequidt <[email protected]>
Co-authored-by: Romain Dequidt <[email protected]>
Co-authored-by: Romain Dequidt <[email protected]>
Co-authored-by: Romain Dequidt <[email protected]>
Co-authored-by: Romain Dequidt <[email protected]>
Co-authored-by: Romain Dequidt <[email protected]>
Co-authored-by: PatrykKuniczak <[email protected]>
@Jonghakseo Are you finish this in the near future? |
Yep. I'm gonna finish this PR after current issue resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If user try to inject it to the place where he can't e.g extension store page/start page, error occur:
|
I think good idea is handle that and create e.g console.error or sth like that for our purpose, then every dev can handle it in they own way, but when they see our exception handling in code, they probably don't forget to handle that case :)
@Jonghakseo Let's slowly end this looong thread 😁 |
IMO, each error message seems to clearly indicate what the problem is, and realistically, there may not be a single cause for every error case. Therefore, I think it is best to leave error handling to the user's responsibility. |
COMMITS
VIDEO
2024-06-16.11.13.12.mov