Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/injecting scripts from popup #579

Merged
merged 10 commits into from
Jul 20, 2024
Merged

Conversation

PatrykKuniczak
Copy link
Collaborator

@PatrykKuniczak PatrykKuniczak commented Jul 15, 2024

I was done it like in #494 for latest version :)

Don't merge this before #559 , because i want to change sth else after merge this PR.

@PatrykKuniczak PatrykKuniczak self-assigned this Jul 15, 2024
@PatrykKuniczak PatrykKuniczak force-pushed the feat/injecting-scripts-#516 branch from ba047e2 to ecbfb71 Compare July 17, 2024 09:06
@PatrykKuniczak PatrykKuniczak marked this pull request as ready for review July 17, 2024 09:06
@PatrykKuniczak
Copy link
Collaborator Author

@Jonghakseo IMO after this, we should bump version to 0.2.0, because of new feature

@PatrykKuniczak PatrykKuniczak force-pushed the feat/injecting-scripts-#516 branch from c771ef4 to 4cfdcd9 Compare July 20, 2024 14:51
@Jonghakseo
Copy link
Owner

@Jonghakseo IMO after this, we should bump version to 0.2.0, because of new feature

I agree

Copy link
Owner

@Jonghakseo Jonghakseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jonghakseo Jonghakseo merged commit 241f4f4 into main Jul 20, 2024
4 checks passed
@Jonghakseo Jonghakseo deleted the feat/injecting-scripts-#516 branch July 20, 2024 16:15
@PatrykKuniczak PatrykKuniczak linked an issue Jul 20, 2024 that may be closed by this pull request
@PatrykKuniczak PatrykKuniczak linked an issue Jul 20, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Injecting scripts from popup for latest version
2 participants