-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added check gha action #32 #34
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Awa Synthia <[email protected]>
@jananiravi Can you review my PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution, @awasyn! This rworkflows action will add many useful checks to the MolEvolvR 📦.
We plan to merge this PR eventually to benefit from CI, but currently, there are many simultaneous changes happening in the repository.
I’ve noted one change we should address in the interim. I’m not opposed to having this workflow manage building the pkgdown website, but at the moment, this check duplicates some functionality. I’d like your perspective on keeping the existing pkgdown action versus implementing the one in this PR.
Signed-off-by: Awa Synthia <[email protected]>
I agree. The pkgdown in rworkflow can be on hold as It won't actually deploy since the checks are bound to fail as a result of incomplete function documentation. Having the current pkgdown workflow is probably the best option to keep the site updated as changes are added. |
Description
The commit adds rworkflows which is a suite of tools to make it easy for R developers to implement reproducible best practices on GitHub.
Check: https://github.com/neurogenomics/rworkflows
Issue: #32
What kind of change(s) are included?
Checklist
Please ensure that all boxes are checked before indicating that this pull request is ready for review.