-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function documentation #97
Conversation
Signed-off-by: Awa Synthia <[email protected]>
Signed-off-by: Awa Synthia <[email protected]>
R/reverse_operons.R
Outdated
#' # Example genomic context data frame | ||
#' prot <- data.frame(GenContext = c("A>B", "C<D", "E=F*G", "H>I")) | ||
#' reversed_prot <- reverseOperonSeq(prot) | ||
#' print(reversed_prot) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@awasyn , can you double check this example code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I will run example again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still seeing an R-CMD check error when running this example:
❯ checking examples ... [14s/15s] ERROR
Running examples in ‘MolEvolvR-Ex.R’ failed
The error most likely occurred in:
> base::assign(".ptime", proc.time(), pos = "CheckExEnv")
> ### Name: reverseOperonSeq
> ### Title: reverseOperon: Reverse the Direction of Operons in Genomic
> ### ContextSeq
> ### Aliases: reverseOperonSeq
>
> ### ** Examples
>
> # Example genomic context data frame
> prot <- data.frame(GenContext = c("A>B", "C<D", "E=F*G", "H>I"))
> reversed_prot <- reverseOperonSeq(prot)
Error in ge[[x]] : subscript out of bounds
Calls: reverseOperonSeq -> lapply -> FUN -> straightenOperonSeq
Execution halted
Using the example data defined in prot
the error occurs during the lapply operation @line 137 as ge
has length 0 due to the previous subset operation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work adding to the package documentation! I've made a few requests for changes (picked some representative examples, but changes should be made throughout).
Overall this looks great and is another step towards enabling the CI in #34
…al issues Signed-off-by: Awa Synthia <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've disabled the reverseOperonSeq() example for now and converted to a new issue so that other changes may be merged. Thanks @awasyn !
Thanks @the-mayer , sorry for the delay. I was finishing my final application for the internship. |
Document parameters
What kind of change(s) are included?
[R-pkg] Status check #2
🐞[BUG] fix check bugs #33
Bug fix (fixes check).(
devtools::document()
) Should be cleaned when merged with: Add parameter definitions to summarize.R #41Enhancement (documentation).
Checklist
Please ensure that all boxes are checked before indicating that this pull request is ready for review.
@the-mayer