Extend eva to support legacy ConMon time/vert data #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdwardSafford-NOAA
requested review from
CoryMartin-NOAA,
kevindougherty-noaa and
ADCollard
CoryMartin-NOAA
approved these changes
Dec 22, 2023
This was referenced Dec 26, 2023
Add support for batch processing on DataType/dtype.
Fix datatype use with station data.
EdwardSafford-NOAA
force-pushed
the
feature/con-167
branch
from
0106637 to
f6eb646
Compare
|
I found I'd missed some changes in handling station data when adding the DataType features. I've also tacked on a change to support datasets for conmon vertical plots. The changes are small but it's probably worth another quick look @CoryMartin-NOAA . |
Merge branch 'develop' into feature/con-167
Add update for conmon vert plots.
CoryMartin-NOAA
approved these changes
Jan 2, 2024
Fix typo.
CoryMartin-NOAA
pushed a commit
to NOAA-EMC/obs-monitor
that referenced
this pull request
Jan 5, 2024
Add a template for conventional time-series plots. Add support for conventional obs in `plotObsMon.py`. This requires a version of eva that includes PR [JCSDA-internal/eva#169 ](url) which is not yet in develop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend
mon_data_space.pyto load legacy ConMon time/vert data files. Additionally clean upmon_data_space.pyby removing unused interface components and consolidate the "magic numbers" used in processing the legacy control files by moving them to the top ofclass MonDataSpaceand giving them descriptive names.Modify additional eva components to allow for batch processing of
DataTypein a manner likeChannelandLevel. This is necessary to make the ConMon time plots.Completes #167
Dependencies
None
Impact
None