Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update online icons #69

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

IAHM-COL
Copy link
Contributor

@IAHM-COL IAHM-COL commented Aug 11, 2021

newConnectIcons

This pull request updates Icons for the online connections

  • Redesign and redraw new icons for the online connections
  • Implement the new icons
  • SVG files are stored in images/src, and can be excluded during packaging of binaries

FICS Icons

  • Icons for Connection to FICS added include Offline, Online and Fetch

  • TODO: The QAction for FICS Connection in the Toolbar could be modded as a toggle; Able to be pushed when offline, leading to connection, or pushed when Online, leading to disconnection. The icon pixmap changing in the QAction to reflect connection status.

  • Icons for Lichess and Chesscom are associated to fetching symbols, since these actions currently simply fetch games from the online databases.

  • I changed the color scheme of chesscom to darkgreen, reflecting actual icon in their website

  • Purple tone of the fetching was adapted from the color scheme of the new icons of the database Toolbar

Note

Commit (df3a461)

This Pull request merges #68

* Updates the Connection Icons for FICS
* Updates the Fetch Icons for FICS Lichess and chesscom
* Stores SVGs as Source files in the src folder
Increasing the size of the Icons in the Help menu from 42 to 64 px width
The Fics toggle will become disable when its pressed to connect to FICS,
and will only become active again if connection is established
succesfully. At this point the pixmap is upated to indicate active
connection
The Fics Toggle executes a disconnect FICS when is checked, connecting
otherwise
@IAHM-COL
Copy link
Contributor Author

IAHM-COL commented Aug 13, 2021

TODO: The QAction for FICS Connection in the Toolbar could be modded as a toggle; Able to be pushed when offline, leading to connection, or pushed when Online, leading to disconnection. The icon pixmap changing in the QAction to reflect connection status.

DONE
Commit (5fad4f1) merges a branch that implements this functionality.

  • When launching, the toggle pixmap shows offline status,
  • Toggle is enabled, and pressing it initializes a fics database opening, and connection

FICSOffline

  • While the connection is established the toggle becomes disabled

fICSConnecting

  • Wishlist: A timeout for the connection could be programmed.

  • Once FICS connection is established and FICS database is open, the toggle pixmap shows online status

  • The toggle appears checked

FicsOnline

  • Toggle is enabled, and pressing it sends a disconnection command, with closure of the database (instead)

  • The Toggle pixmap returns to the beginning, indicating that FICS is disconnected.

@IAHM-COL IAHM-COL mentioned this pull request Aug 17, 2021
@IAHM-COL IAHM-COL mentioned this pull request Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant