Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split workflow in multiple jobs #140

Closed
wants to merge 1 commit into from
Closed

Split workflow in multiple jobs #140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
on: pull_request
jobs:
build:
Lint:
runs-on: ubuntu-latest
# Continue to the next step even if this fails
continue-on-error: true
Copy link
Member

@KwikKill KwikKill Oct 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pipeline need to be able to fail and every job will still be completed even without continue-on-error.
For reference, this is the difference between with and without it :
image
Both pipelines are supposed to fail when certain steps have failed, but with continue-on-error, the pipeline doesn't.

steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
Expand All @@ -16,12 +18,23 @@ jobs:
# Continue to the next step even if this fails
continue-on-error: true

- name: Typecheck
run: npx vue-tsc --noEmit
# Continue to the next step even if this fails
continue-on-error: true

- name: Annotate Code Linting Results
uses: ataylorme/eslint-annotate-action@v2
with:
markdown-report-on-step-summary: true

Typecheck:
runs-on: ubuntu-latest
# Continue to the next step even if this fails
continue-on-error: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 'lts/*'

- name: Install modules
run: npm ci

- name: Run Typecheck
run: npx vue-tsc --noEmit