Split workflow in multiple jobs #140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KwikKill
requested changes
Oct 2, 2024
| runs-on: ubuntu-latest | ||
| # Continue to the next step even if this fails | ||
| continue-on-error: true |
There was a problem hiding this comment.
The pipeline need to be able to fail and every job will still be completed even without continue-on-error.
For reference, this is the difference between with and without it :
Both pipelines are supposed to fail when certain steps have failed, but with continue-on-error, the pipeline doesn't.
| Typecheck: | ||
| runs-on: ubuntu-latest | ||
| # Continue to the next step even if this fails | ||
| continue-on-error: true |
|
This modification was included in #142 as a larger refacto was made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With continue-on-error on steps, when that step fail, it marked as succeeded.
However, having continue-on-error at the job level marks the job as failed but continue to the next job.
This PR split the workflow in two jobs to be able to have the job marked as failed when a step fails but continue to the next job.