Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Box Select 컴포넌트 추가 #23

Merged
merged 10 commits into from
Sep 6, 2024
Merged

feat: Box Select 컴포넌트 추가 #23

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f93ef38
[KAN-11] feat: BoxSelect 컴포넌트 (데스크톱 버전) 추가
BeMatthewsong Sep 6, 2024
54d3a39
[KAN-11] chore: tailwind 미디어쿼리 설정 추가
BeMatthewsong Sep 6, 2024
0a2facd
[KAN-11] style: BoxSelect 컴포넌트 (모바일 버전) 추가 및 trasition 추가
BeMatthewsong Sep 6, 2024
88af76f
Merge branch 'develop' into feat/hyuk/KAN-12-Box-Selector
BeMatthewsong Sep 6, 2024
830cee4
[KAN-11] fix: 상위 태그를 label 태그로 교체
BeMatthewsong Sep 6, 2024
e14a4cc
[KAN-11] style: 스크린 사이즈에 따른 전체 높이 조절
BeMatthewsong Sep 6, 2024
01b24a2
[KAN-11] chore: 불필요한 코드 삭제
BeMatthewsong Sep 6, 2024
4608ecf
[KAN-11] chore: ChangeEvent Import
BeMatthewsong Sep 6, 2024
73c6ca8
[KAN-11] chore: 불필요한 코드 삭제
BeMatthewsong Sep 6, 2024
1b4e897
[KAN-11] fix: 변수명 변경 및 테일윈드 수정
BeMatthewsong Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

43 changes: 43 additions & 0 deletions src/app/components/BoxSelect/BoxSelect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
'use client';

import { ChangeEvent, useState } from 'react';

/**
* BoxSelect component
* @param {string} title - 제목
* @param {string} subTitle - 부제목
*/

interface BoxSelectProps {
title: string;
subTitle: string;
}

const BoxSelect = ({ title = '', subTitle = '' }: BoxSelectProps) => {
const [selectStatus, setSelectStatus] = useState<boolean>(false);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

나중에 부모 컴포넌트에서 set함수를 받아서 관리할 것 같아서 이 부분은 추후에 변경이 필요해보입니다.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3) state 이름을 isSelected 라고 변경해도 좋을 것 같습니다!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아하 확실히 그게 더 좋겠네요!
반영하도록 하겠습니다!


const handleCheckboxChange = (event: ChangeEvent<HTMLInputElement>) => {
setSelectStatus(event.target.checked);
};

return (
<label
className={`flex h-76 w-full items-start gap-8 rounded-lg ${selectStatus ? 'bg-var-gray-900 text-var-white' : 'bg-var-gray-50 text-var-black'} md:h-70 lg:h-70 px-8 py-[6px] transition-colors duration-200 ease-in-out md:px-16 md:py-12 lg:px-16 lg:py-12`}
>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

<input
id='checkbox'
type='checkbox'
className="h-24 w-24 appearance-none rounded-md bg-[url('/icons/checkbox-default.svg')] bg-center bg-no-repeat checked:bg-[url('/icons/checkbox-active.svg')] checked:bg-center checked:bg-no-repeat"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P4) appearance 속성은 처음 보네요! 혹시 어떤 기능하는지 알려주실 수 있을까요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

appearance-none은 체크박스 인풋의 기본 스타일을 무효화시키는 속성입니다.

https://tailwindcss.com/docs/appearance

onChange={handleCheckboxChange}
/>
<div className='flex flex-col'>
<div className='text-[14px] font-bold md:text-[16px] lg:text-[16px]'>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2) md 이상이면 text 가 16px 인 것 같아서 굳이 lg:text-[16px] 은 안 적어도 될 것 같긴 합니다!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • text-16 , text-14 로 사용 할 수 있게 tailwind config 수정했습니다!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

두 분 의견 반영하겠습니다!

{title}
</div>
<div className='text-[12px] font-medium'>{subTitle}</div>
</div>
</label>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • label 를 상위 태그로 두면서 전체를 클릭하여도 input이 선택되도록 하였습니다.
  • selectStatus에 따라 체크박스에 해당하는 이미지가 변하도록 하였습니다.
  • transition을 넣으면서 부드러운 전환을 할 수 있게 했습니다.

);
};

export default BoxSelect;
4 changes: 4 additions & 0 deletions tailwind.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ const config: Config = {
'./src/app/**/*.{js,ts,jsx,tsx,mdx}',
],
theme: {
screens: {
md: { min: '768px' },
lg: { min: '1024px' },
},
Comment on lines +21 to +24
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

extend: {
spacing: PX_ENTRIES,
fontFamily: {
Expand Down
Loading